Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency in CMake presets #14140

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented Sep 15, 2022

Building CMake presets ninja-release-gandiva and ninja-debug-gandiva fails with a link error saying utf8proc related definitions are not found. It's because ARROW_WITH_UTF8PROC is explicitly turned off in these two presets but is required to build Gandiva.

Add set(ARROW_WITH_UTF8PROC ON) if ARROW_GANDIVA solves the issue. An alternative solution is to enable ARROW_WITH_UTF8PROC in the preset settings. But I think the current solution is more general.

@js8544 js8544 changed the title ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency in CMake presets Sep 15, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit e63a13a into apache:master Sep 15, 2022
@ursabot
Copy link

ursabot commented Sep 16, 2022

Benchmark runs are scheduled for baseline = bced07d and contender = e63a13a. e63a13a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e63a13aa ec2-t3-xlarge-us-east-2
[Failed] e63a13aa test-mac-arm
[Failed] e63a13aa ursa-i9-9960x
[Finished] e63a13aa ursa-thinkcentre-m75q
[Finished] bced07de ec2-t3-xlarge-us-east-2
[Failed] bced07de test-mac-arm
[Failed] bced07de ursa-i9-9960x
[Finished] bced07de ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…presets (apache#14140)

Building CMake presets `ninja-release-gandiva` and `ninja-debug-gandiva` fails with a link error saying utf8proc related definitions are not found. It's because `ARROW_WITH_UTF8PROC` is explicitly turned off in these two presets but is required to build Gandiva.

Add `set(ARROW_WITH_UTF8PROC ON)` if `ARROW_GANDIVA` solves the issue. An alternative solution is to enable `ARROW_WITH_UTF8PROC` in the preset settings. But I think the current solution is more general.

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@js8544 js8544 deleted the jinshang/gandiva/fix_utf8proc_dependency branch October 11, 2022 08:43
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…presets (apache#14140)

Building CMake presets `ninja-release-gandiva` and `ninja-debug-gandiva` fails with a link error saying utf8proc related definitions are not found. It's because `ARROW_WITH_UTF8PROC` is explicitly turned off in these two presets but is required to build Gandiva.

Add `set(ARROW_WITH_UTF8PROC ON)` if `ARROW_GANDIVA` solves the issue. An alternative solution is to enable `ARROW_WITH_UTF8PROC` in the preset settings. But I think the current solution is more general.

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants