-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency in CMake presets #14140
ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency in CMake presets #14140
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = bced07d and contender = e63a13a. e63a13a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…presets (apache#14140) Building CMake presets `ninja-release-gandiva` and `ninja-debug-gandiva` fails with a link error saying utf8proc related definitions are not found. It's because `ARROW_WITH_UTF8PROC` is explicitly turned off in these two presets but is required to build Gandiva. Add `set(ARROW_WITH_UTF8PROC ON)` if `ARROW_GANDIVA` solves the issue. An alternative solution is to enable `ARROW_WITH_UTF8PROC` in the preset settings. But I think the current solution is more general. Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…presets (apache#14140) Building CMake presets `ninja-release-gandiva` and `ninja-debug-gandiva` fails with a link error saying utf8proc related definitions are not found. It's because `ARROW_WITH_UTF8PROC` is explicitly turned off in these two presets but is required to build Gandiva. Add `set(ARROW_WITH_UTF8PROC ON)` if `ARROW_GANDIVA` solves the issue. An alternative solution is to enable `ARROW_WITH_UTF8PROC` in the preset settings. But I think the current solution is more general. Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Building CMake presets
ninja-release-gandiva
andninja-debug-gandiva
fails with a link error saying utf8proc related definitions are not found. It's becauseARROW_WITH_UTF8PROC
is explicitly turned off in these two presets but is required to build Gandiva.Add
set(ARROW_WITH_UTF8PROC ON)
ifARROW_GANDIVA
solves the issue. An alternative solution is to enableARROW_WITH_UTF8PROC
in the preset settings. But I think the current solution is more general.