Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [R] Fix lint warnings and run styler over everything #14153

Merged
merged 3 commits into from
Sep 16, 2022
Merged

MINOR: [R] Fix lint warnings and run styler over everything #14153

merged 3 commits into from
Sep 16, 2022

Conversation

nealrichardson
Copy link
Member

No description provided.

paleolimbot
paleolimbot approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs green CI, but looks great to me! Thanks!

@nealrichardson nealrichardson merged commit 6bc2e01 into apache:master Sep 16, 2022
@nealrichardson nealrichardson deleted the lint-fix branch September 16, 2022 17:18
@ursabot
Copy link

ursabot commented Sep 17, 2022

Benchmark runs are scheduled for baseline = e3be15f and contender = 6bc2e01. 6bc2e01 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.1% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6bc2e010 ec2-t3-xlarge-us-east-2
[Failed] 6bc2e010 test-mac-arm
[Failed] 6bc2e010 ursa-i9-9960x
[Finished] 6bc2e010 ursa-thinkcentre-m75q
[Finished] e3be15f3 ec2-t3-xlarge-us-east-2
[Finished] e3be15f3 test-mac-arm
[Failed] e3be15f3 ursa-i9-9960x
[Finished] e3be15f3 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 17, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@nealrichardson @zagto
MINOR: [R] Fix lint warnings and run styler over everything (apache#1…
777f8a8 
…4153)

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@nealrichardson @fatemehp
MINOR: [R] Fix lint warnings and run styler over everything (apache#1…
d1bfb21 
…4153)

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nealrichardson @ursabot @paleolimbot