Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17737: [R] Groups before conversion to a Table must not be restored after collect() #14175

Merged
merged 22 commits into from
Oct 14, 2022
Merged

ARROW-17737: [R] Groups before conversion to a Table must not be restored after collect() #14175

merged 22 commits into from
Oct 14, 2022

Commits on Oct 14, 2022

  1. add tests for compute 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6659080 View commit details
    Browse the repository at this point in the history

  2. rename file to match name of file to be tested 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    55d803d View commit details
    Browse the repository at this point in the history

  3. fix tests 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    cd8fa1d View commit details
    Browse the repository at this point in the history

  4. remove unused line 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    9e1c73b View commit details
    Browse the repository at this point in the history

  5. Revert "rename file to match name of file to be tested" 

    This reverts commit 83eafbe.
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    71c170f View commit details
    Browse the repository at this point in the history

  6. move test to the other file and rename the test case 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    fd4b15e View commit details
    Browse the repository at this point in the history

  7. add tests for compute and collect 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    2fab634 View commit details
    Browse the repository at this point in the history

  8. more test 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7830d2c View commit details
    Browse the repository at this point in the history

  9. use NULL for empty group vars, and remove group vars metadata from .data 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    dc19476 View commit details
    Browse the repository at this point in the history

  10. restore group vars from arrow dplyr query to Table 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    cae1f26 View commit details
    Browse the repository at this point in the history

  11. arrow_dplyr_query$group_by_vars should character, and metadata$r$attr… 

    …ibutes$.group_vars should not character(0)

Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    73edf12 View commit details
    Browse the repository at this point in the history

  12. fix 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f6d2a0d View commit details
    Browse the repository at this point in the history

  13. use as_arrow_table instead of collect 

    because of Table with 0 columns handling

Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    da80d76 View commit details
    Browse the repository at this point in the history

  14. fix typo 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3012a54 View commit details
    Browse the repository at this point in the history

  15. add tests 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    d0c545f View commit details
    Browse the repository at this point in the history

  16. add tests 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ce5d581 View commit details
    Browse the repository at this point in the history

  17. ensure not to convert to a grouped_df 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e117e8c View commit details
    Browse the repository at this point in the history

  18. change to manipulate groups only when necessary 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    36674d1 View commit details
    Browse the repository at this point in the history

  19. separate the test case 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8b5ef46 View commit details
    Browse the repository at this point in the history

  20. fix rebasing 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8a1f7cd View commit details
    Browse the repository at this point in the history

  21. ensure ungroup .data if it is a Table 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    72a5ab6 View commit details
    Browse the repository at this point in the history

  22. more simplify 

    Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
    @eitsupi @nealrichardson
    eitsupi authored and nealrichardson committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    a706268 View commit details
    Browse the repository at this point in the history