ARROW-17693: [C++] Remove string_view backport #14177

pitrou · 2022-09-20T16:07:45Z

No description provided.

github-actions · 2022-09-20T16:53:10Z

https://issues.apache.org/jira/browse/ARROW-17693

github-actions · 2022-09-20T16:53:11Z

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

pitrou · 2022-09-20T18:53:14Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -1974,9 +1974,8 @@ macro(build_gtest)
  set(dummy ">")

  set(GTEST_CMAKE_ARGS
-      ${EP_COMMON_TOOLCHAIN}
+      ${EP_COMMON_CMAKE_ARGS}


This is so that CMAKE_CXX_STANDARD is propagated to the GTest build.

pitrou · 2022-09-20T20:07:18Z

Revision: c7e43c9

Submitted crossbow builds: ursacomputing/crossbow @ string-view-5

Task	Status
almalinux-8-amd64
almalinux-8-arm64
almalinux-9-amd64
almalinux-9-arm64
amazon-linux-2-amd64
amazon-linux-2-arm64
centos-7-amd64
centos-8-stream-amd64
centos-8-stream-arm64
centos-9-stream-amd64
centos-9-stream-arm64
conan-maximum
conan-minimum
conda-clean
conda-linux-gcc-py310-arm64
conda-linux-gcc-py310-cpu
conda-linux-gcc-py310-cuda
conda-linux-gcc-py310-ppc64le
conda-linux-gcc-py37-arm64
conda-linux-gcc-py37-cpu-r40
conda-linux-gcc-py37-cpu-r41
conda-linux-gcc-py37-cuda
conda-linux-gcc-py37-ppc64le
conda-linux-gcc-py38-arm64
conda-linux-gcc-py38-cpu
conda-linux-gcc-py38-cuda
conda-linux-gcc-py38-ppc64le
conda-linux-gcc-py39-arm64
conda-linux-gcc-py39-cpu
conda-linux-gcc-py39-cuda
conda-linux-gcc-py39-ppc64le
conda-osx-arm64-clang-py310
conda-osx-arm64-clang-py38
conda-osx-arm64-clang-py39
conda-osx-clang-py310
conda-osx-clang-py37-r40
conda-osx-clang-py37-r41
conda-osx-clang-py38
conda-osx-clang-py39
conda-win-vs2019-py310
conda-win-vs2019-py37-r40
conda-win-vs2019-py37-r41
conda-win-vs2019-py38
conda-win-vs2019-py39
debian-bookworm-amd64
debian-bookworm-arm64
debian-bullseye-amd64
debian-bullseye-arm64
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
homebrew-cpp
homebrew-r-autobrew
homebrew-r-brew
java-jars
nuget
python-sdist
r-binary-packages
test-alpine-linux-cpp
test-build-cpp-fuzz
test-build-vcpkg-win
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.10
test-conda-python-3.7
test-conda-python-3.7-hdfs-2.9.2
test-conda-python-3.7-hdfs-3.2.1
test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
test-conda-python-3.7-pandas-0.24
test-conda-python-3.7-pandas-latest
test-conda-python-3.7-spark-v3.1.2
test-conda-python-3.8
test-conda-python-3.8-hypothesis
test-conda-python-3.8-pandas-latest
test-conda-python-3.8-pandas-nightly
test-conda-python-3.8-spark-v3.2.0
test-conda-python-3.9
test-conda-python-3.9-dask-latest
test-conda-python-3.9-dask-master
test-conda-python-3.9-pandas-master
test-conda-python-3.9-spark-master
test-debian-10-cpp-amd64
test-debian-10-cpp-i386
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-debian-11-go-1.17
test-debian-11-python-3
test-debian-c-glib
test-debian-ruby
test-fedora-35-cpp
test-fedora-35-python-3
test-fedora-r-clang-sanitizer
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-gcc-release-latest
test-r-rocker-r-base-latest
test-r-rstudio-r-base-4.1-opensuse153
test-r-rstudio-r-base-4.2-centos7-devtoolset-8
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-skyhook-integration
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-18.04-r-sanitizer
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.04-python-3
test-ubuntu-22.04-cpp
test-ubuntu-c-glib
test-ubuntu-default-docs
test-ubuntu-ruby
ubuntu-bionic-amd64
ubuntu-bionic-arm64
ubuntu-focal-amd64
ubuntu-focal-arm64
ubuntu-jammy-amd64
ubuntu-jammy-arm64
wheel-macos-big-sur-cp310-arm64
wheel-macos-big-sur-cp310-universal2
wheel-macos-big-sur-cp38-arm64
wheel-macos-big-sur-cp39-arm64
wheel-macos-big-sur-cp39-universal2
wheel-macos-mojave-cp310-amd64
wheel-macos-mojave-cp37-amd64
wheel-macos-mojave-cp38-amd64
wheel-macos-mojave-cp39-amd64
wheel-manylinux2014-cp310-amd64
wheel-manylinux2014-cp310-arm64
wheel-manylinux2014-cp37-amd64
wheel-manylinux2014-cp37-arm64
wheel-manylinux2014-cp38-amd64
wheel-manylinux2014-cp38-arm64
wheel-manylinux2014-cp39-amd64
wheel-manylinux2014-cp39-arm64
wheel-windows-cp310-amd64
wheel-windows-cp37-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64

kou

+1

kou · 2022-09-21T01:56:50Z

.github/workflows/cpp.yml

@@ -146,8 +146,7 @@ jobs:
      ARROW_WITH_SNAPPY: ON
      ARROW_WITH_ZLIB: ON
      ARROW_WITH_ZSTD: ON
-      # System Abseil installed by Homebrew uses C++ 17
-      CMAKE_CXX_STANDARD: 17
+      GTest_SOURCE: BUNDLED


Why do we need this? Do we need newer GTest for std::string_view? If so, how about updating required GTest version too? https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2078

The GTest version does not need to be new, but GTest needs to be compiled in C++17 mode otherwise some test helpers are needed (such as equality between string_views).

pitrou · 2022-09-21T08:11:39Z

Ok, all CI failures are unrelated, I'll merge.

ursabot · 2022-09-21T13:02:01Z

Benchmark runs are scheduled for baseline = afd3c40 and contender = 91ee6da. 91ee6da is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.57% ⬆️0.61%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.56%] ursa-i9-9960x
[Finished ⬇️1.1% ⬆️0.85%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 91ee6dad ec2-t3-xlarge-us-east-2
[Failed] 91ee6dad test-mac-arm
[Failed] 91ee6dad ursa-i9-9960x
[Finished] 91ee6dad ursa-thinkcentre-m75q
[Finished] afd3c40a ec2-t3-xlarge-us-east-2
[Failed] afd3c40a test-mac-arm
[Failed] afd3c40a ursa-i9-9960x
[Finished] afd3c40a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

ARROW-17693: [C++] Remove string_view backport

18e4989

This comment was marked as outdated.

Sign in to view

github-actions bot added Component: Documentation Component: FlightRPC Component: C++ - Gandiva Component: C++ Component: GLib Component: Python Component: R Component: Parquet labels Sep 20, 2022

pitrou force-pushed the ARROW-17693-std-string-view branch from 9845b80 to c9a2044 Compare September 20, 2022 17:02

This comment was marked as outdated.

Sign in to view

pitrou force-pushed the ARROW-17693-std-string-view branch from c9a2044 to 9f63712 Compare September 20, 2022 17:32

This comment was marked as outdated.

Sign in to view

Try to fix CI failures

3fbeb9a

pitrou force-pushed the ARROW-17693-std-string-view branch from 9f63712 to 3fbeb9a Compare September 20, 2022 17:53

Try to fix JNI build

f92c450

pitrou force-pushed the ARROW-17693-std-string-view branch from 62bbdcf to f92c450 Compare September 20, 2022 18:50

This comment was marked as outdated.

Sign in to view

pitrou commented Sep 20, 2022

View reviewed changes

pitrou requested a review from kou September 20, 2022 18:53

Use bundled GTest in more places

c7e43c9

Try to workaround GTest linking issue on macOS

dca67f9

kou approved these changes Sep 21, 2022

View reviewed changes

pitrou merged commit 91ee6da into apache:master Sep 21, 2022

pitrou deleted the ARROW-17693-std-string-view branch September 21, 2022 08:12

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022

ARROW-17693: [C++] Remove string_view backport (apache#14177)

0597968

Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022

ARROW-17693: [C++] Remove string_view backport (apache#14177)

4df0e44

Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

asfimport mentioned this pull request Sep 21, 2022

[C++] Remove string_view backport #32932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-17693: [C++] Remove string_view backport #14177

ARROW-17693: [C++] Remove string_view backport #14177

pitrou commented Sep 20, 2022

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

pitrou Sep 20, 2022

pitrou commented Sep 20, 2022

kou left a comment

kou Sep 21, 2022

pitrou Sep 21, 2022

kou Sep 21, 2022

pitrou commented Sep 21, 2022

ursabot commented Sep 21, 2022

ARROW-17693: [C++] Remove string_view backport #14177

ARROW-17693: [C++] Remove string_view backport #14177

Conversation

pitrou commented Sep 20, 2022

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

pitrou Sep 20, 2022

Choose a reason for hiding this comment

pitrou commented Sep 20, 2022

kou left a comment

Choose a reason for hiding this comment

kou Sep 21, 2022

Choose a reason for hiding this comment

pitrou Sep 21, 2022

Choose a reason for hiding this comment

kou Sep 21, 2022

Choose a reason for hiding this comment

pitrou commented Sep 21, 2022

ursabot commented Sep 21, 2022