ARROW-17788: [R][Doc] Add example of using Scanner #14184
Conversation
|
|
wjones127
changed the title
r/R/dataset-scan.R
Outdated
| #' dir.create(tf) | ||
| #' on.exit(unlink(tf)) | ||
| #' | ||
| #' data <- dplyr::group_by(mtcars, cyl) |
There was a problem hiding this comment.
Given we don't have dplyr as a dependency, could it be worth removing the group_by() call here, and manually specifying the partitioning argument to write_dataset() instead?
There was a problem hiding this comment.
Good point. I've replace the call I added as well as the one in the other example I copied from.
wjones127
force-pushed
the
ARROW-17788-r-scanner-example
branch
from
ad62dc5
to
d6cb1f7
Compare
|
Lots of CI failures here, should this be rebased? |
| @@ -131,8 +131,7 @@ | |||
| #' dir.create(tf) | |||
| #' on.exit(unlink(tf)) | |||
| #' | |||
| #' data <- dplyr::group_by(mtcars, cyl) | |||
There was a problem hiding this comment.
The complete removal of data here breaks the example further down write_dataset(data, tf2, format = "ipc") - please can you update that too?
There was a problem hiding this comment.
Thanks for pointing that out. I've updated that example and tested locally on my computer to make sure it works now.
My bad, missed an error caused by a change as reviewed before the CI had finished running - doesn't need rebasing. Added feedback now. |
wjones127
force-pushed
the
ARROW-17788-r-scanner-example
branch
from
d6cb1f7
to
78a8816
Compare
|
Benchmark runs are scheduled for baseline = 66e8ba5 and contender = 959a9d5. 959a9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.