Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17803: [C++] Use [[nodiscard]] #14193

Merged
merged 2 commits into from
Sep 22, 2022
Merged

ARROW-17803: [C++] Use [[nodiscard]] #14193

merged 2 commits into from
Sep 22, 2022

Commits on Sep 22, 2022

  1. ARROW-17803: [C++] Use [[nodiscard]] 

    C++17 supports the standard attribute `[[nodiscard]]`, use that instead of the clang-specific `__attribute__((warn_unused_result))`.
    @pitrou
    pitrou committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    aaf3490 View commit details
    Browse the repository at this point in the history

  2. See if __declspec works better for exported friends

    @pitrou
    pitrou committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    29d4bfa View commit details
    Browse the repository at this point in the history