Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17815: [Python] Warn, not error out, when SetSignalStopSource fails #14205

Merged
merged 1 commit into from
Sep 22, 2022
Merged

ARROW-17815: [Python] Warn, not error out, when SetSignalStopSource fails #14205

merged 1 commit into from
Sep 22, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 22, 2022

In complex scenarios, the global signal-receiving StopSource may have already been created.

@pitrou
ARROW-17815: [Python] Warn, not error out, when a SignalStopSource is…
74e84da 
… already set

In complex scenarios, the global signal-receiving StopSource may have already been created.
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17815

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

paleolimbot
paleolimbot approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pitrou pitrou merged commit b0d74bd into apache:master Sep 22, 2022
@pitrou pitrou deleted the ARROW-17815-signal-stop-warn branch September 22, 2022 12:23
@ursabot
Copy link

ursabot commented Sep 22, 2022

Benchmark runs are scheduled for baseline = 311fe3e and contender = b0d74bd. b0d74bd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.24% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b0d74bd0 ec2-t3-xlarge-us-east-2
[Failed] b0d74bd0 test-mac-arm
[Failed] b0d74bd0 ursa-i9-9960x
[Finished] b0d74bd0 ursa-thinkcentre-m75q
[Finished] 311fe3e8 ec2-t3-xlarge-us-east-2
[Finished] 311fe3e8 test-mac-arm
[Failed] 311fe3e8 ursa-i9-9960x
[Finished] 311fe3e8 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou @zagto
ARROW-17815: [Python] Warn, not error out, when SetSignalStopSource f…
47581c2 
…ails (apache#14205)

In complex scenarios, the global signal-receiving StopSource may have already been created.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@pitrou @fatemehp
ARROW-17815: [Python] Warn, not error out, when SetSignalStopSource f…
6d473d2 
…ails (apache#14205)

In complex scenarios, the global signal-receiving StopSource may have already been created.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitrou @ursabot @paleolimbot