Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17458: [C++] Cast between decimal and string #14232

Merged
merged 15 commits into from
Oct 26, 2022

Conversation

quanghgx
Copy link
Contributor

@quanghgx quanghgx commented Sep 25, 2022

  • Update cast_string and cast_decimal function kernels to support string <--> decimal
  • Rely on existing converter/parser: Decimal::ToString, Decimal::FromString
  • Follow current layout closely

Relates to: https://issues.apache.org/jira/browse/ARROW-17042 and https://issues.apache.org/jira/browse/ARROW-17458

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm lidavidm changed the title ARROW-17458: cast between decimal and string ARROW-17458: [C++] Cast between decimal and string Sep 26, 2022
@quanghgx quanghgx force-pushed the ARROW-17458_decimal_to_utf8_cast branch from faee674 to 48c15c0 Compare October 9, 2022 12:37
@quanghgx quanghgx force-pushed the ARROW-17458_decimal_to_utf8_cast branch 2 times, most recently from cdb7f61 to 3d19da5 Compare October 21, 2022 16:50
@quanghgx quanghgx marked this pull request as ready for review October 21, 2022 16:58
@quanghgx
Copy link
Contributor Author

Hi @westonpace
This PR is ready for review. It relates to both ARROW-17042 and ARROW-17458

For 2 failed CI checks, it seems, they are not related to this change set:
https://github.com/apache/arrow/actions/runs/3302286318/jobs/5448920608#step:6:2863
https://github.com/apache/arrow/actions/runs/3302286320/jobs/5448920508#step:7:7533

Sincerely,

@quanghgx quanghgx force-pushed the ARROW-17458_decimal_to_utf8_cast branch from 6d65e2a to 4029683 Compare October 24, 2022 16:03
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in the compute kernel but this looks pretty complete to me. I just have one small question. Thanks for the contribution.

@westonpace westonpace merged commit e9f0b3f into apache:master Oct 26, 2022
@ursabot
Copy link

ursabot commented Oct 29, 2022

Benchmark runs are scheduled for baseline = b87370d and contender = e9f0b3f. e9f0b3f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e9f0b3f7 ec2-t3-xlarge-us-east-2
[Failed] e9f0b3f7 test-mac-arm
[Finished] e9f0b3f7 ursa-i9-9960x
[Failed] e9f0b3f7 ursa-thinkcentre-m75q
[Finished] b87370d6 ec2-t3-xlarge-us-east-2
[Failed] b87370d6 test-mac-arm
[Finished] b87370d6 ursa-i9-9960x
[Finished] b87370d6 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@quanghgx quanghgx deleted the ARROW-17458_decimal_to_utf8_cast branch October 30, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants