Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17842: [C++][CI] Use Brew installed clang for MacOS verify-rc #14236

Merged
merged 2 commits into from
Sep 27, 2022
Merged

ARROW-17842: [C++][CI] Use Brew installed clang for MacOS verify-rc #14236

merged 2 commits into from
Sep 27, 2022

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented Sep 26, 2022

Same problem as #14187 (comment)

@js8544
Copy link
Collaborator Author

js8544 commented Sep 26, 2022

@github-actions crossbow submit -g nightly

@js8544
Copy link
Collaborator Author

js8544 commented Sep 26, 2022 •
edited
Loading

@github-actions crossbow submit -g nightly

Hmm not sure if I have the privilege to call it. @cyb70289 do you mind initiating a crossbow nightly build for this PR?

EDIT: Never mind. The bot has a slow reaction time.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17842

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions

This comment was marked as outdated.

Sign in to view
@js8544
Copy link
Collaborator Author

js8544 commented Sep 26, 2022

@github-actions crossbow submit -g nightly

@kou
Copy link
Member

kou commented Sep 26, 2022

FYI: We can use nightly-release instead of nightly for our verification jobs: https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L184

dev/tasks/tasks.yml defines nightly group but we don't use it in nightly jobs. We're using nightly-tests, nightly-packaging and nightly-release instead: https://lists.apache.org/list.html?builds@arrow.apache.org

@github-actions

This comment was marked as outdated.

Sign in to view
@cyb70289
Copy link
Contributor

Which tests are to be fixed by this PR? @js8544

@js8544
Copy link
Collaborator Author

js8544 commented Sep 27, 2022 •
edited
Loading

Which tests are to be fixed by this PR? @js8544

verify-rc-source-cpp-macos-amd64. But there appears to be other issues with this test. I'll let you know when I fix them.

@js8544 js8544 force-pushed the jinshang/brew_clang_mac_verify_rc branch from 4895b73 to 4120ecd Compare September 27, 2022 02:54
@js8544
Copy link
Collaborator Author

js8544 commented Sep 27, 2022

@github-actions crossbow submit -g nightly-release

@github-actions
Copy link

Revision: 4120ecd

Submitted crossbow builds: ursacomputing/crossbow @ actions-8fdf7a3079

Task Status
verify-rc-source-cpp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-cpp-linux-conda-latest-amd64 Github Actions
verify-rc-source-cpp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-cpp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-cpp-macos-amd64 Github Actions
verify-rc-source-cpp-macos-arm64 Github Actions
verify-rc-source-cpp-macos-conda-amd64 Github Actions
verify-rc-source-csharp-linux-almalinux-8-amd64 Github Actions
verify-rc-source-csharp-linux-conda-latest-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions
verify-rc-source-go-linux-almalinux-8-amd64 Github Actions
verify-rc-source-go-linux-conda-latest-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-go-macos-amd64 Github Actions
verify-rc-source-go-macos-arm64 Github Actions
verify-rc-source-integration-linux-almalinux-8-amd64 Github Actions
verify-rc-source-integration-linux-conda-latest-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-integration-macos-amd64 Github Actions
verify-rc-source-integration-macos-arm64 Github Actions
verify-rc-source-integration-macos-conda-amd64 Github Actions
verify-rc-source-java-linux-almalinux-8-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions
verify-rc-source-js-linux-almalinux-8-amd64 Github Actions
verify-rc-source-js-linux-conda-latest-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-js-macos-amd64 Github Actions
verify-rc-source-js-macos-arm64 Github Actions
verify-rc-source-python-linux-almalinux-8-amd64 Github Actions
verify-rc-source-python-linux-conda-latest-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-python-macos-amd64 Github Actions
verify-rc-source-python-macos-arm64 Github Actions
verify-rc-source-python-macos-conda-amd64 Github Actions
verify-rc-source-ruby-linux-almalinux-8-amd64 Github Actions
verify-rc-source-ruby-linux-conda-latest-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-ruby-macos-amd64 Github Actions
verify-rc-source-ruby-macos-arm64 Github Actions
verify-rc-source-windows Github Actions

@js8544
Copy link
Collaborator Author

js8544 commented Sep 27, 2022

The three verify-rc-source-cpp-macos tests are green now. cc @kou @cyb70289

kou
kou approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit f277f2e into apache:master Sep 27, 2022
@ursabot
Copy link

ursabot commented Sep 27, 2022

Benchmark runs are scheduled for baseline = 53ac2a0 and contender = f277f2e. f277f2e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.14% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.85% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f277f2e5 ec2-t3-xlarge-us-east-2
[Failed] f277f2e5 test-mac-arm
[Failed] f277f2e5 ursa-i9-9960x
[Finished] f277f2e5 ursa-thinkcentre-m75q
[Finished] 53ac2a00 ec2-t3-xlarge-us-east-2
[Finished] 53ac2a00 test-mac-arm
[Failed] 53ac2a00 ursa-i9-9960x
[Finished] 53ac2a00 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@js8544 js8544 deleted the jinshang/brew_clang_mac_verify_rc branch October 11, 2022 08:43
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@js8544 @fatemehp
ARROW-17842: [C++][CI] Use Brew installed clang for MacOS verify-rc (a…
43e05ac 
…pache#14236)

Same problem as apache#14187 (comment)

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: FlightRPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@js8544 @kou @cyb70289 @ursabot