Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17813: [Python] Nested ExtensionArray conversion to/from pandas/numpy #14238

Merged
merged 14 commits into from
Oct 12, 2022
Merged

ARROW-17813: [Python] Nested ExtensionArray conversion to/from pandas/numpy #14238

merged 14 commits into from
Oct 12, 2022

Conversation

milesgranger
Copy link
Contributor

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

python/pyarrow/src/arrow_to_pandas.cc Outdated Show resolved Hide resolved
python/pyarrow/src/arrow_to_pandas.cc Outdated Show resolved Hide resolved
python/pyarrow/src/arrow_to_pandas.cc Outdated Show resolved Hide resolved
python/pyarrow/src/arrow_to_pandas.cc Outdated Show resolved Hide resolved
@milesgranger milesgranger marked this pull request as ready for review September 29, 2022 08:40
@jorisvandenbossche
Copy link
Member

cc @emkornfield

@jorisvandenbossche
Copy link
Member

To me this PR looks good to go. I just added a comment on ARROW-17535 to see whether we are OK with this for to_pandas, while that JIRA argues for a more complex solution to honor the ExtensionType's custom conversion.

@jorisvandenbossche
Copy link
Member

@milesgranger the failures here are actually related

milesgranger and others added 2 commits October 12, 2022 08:50
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche merged commit 21ba22b into apache:master Oct 12, 2022
@milesgranger milesgranger deleted the ARROW-17813_nested-estension-conversion branch October 12, 2022 13:59
@ursabot
Copy link

ursabot commented Oct 13, 2022

Benchmark runs are scheduled for baseline = 3a72dc0 and contender = 21ba22b. 21ba22b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️1.64% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 21ba22bf ec2-t3-xlarge-us-east-2
[Failed] 21ba22bf test-mac-arm
[Failed] 21ba22bf ursa-i9-9960x
[Finished] 21ba22bf ursa-thinkcentre-m75q
[Finished] 3a72dc0e ec2-t3-xlarge-us-east-2
[Failed] 3a72dc0e test-mac-arm
[Failed] 3a72dc0e ursa-i9-9960x
[Finished] 3a72dc0e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@emkornfield
Copy link
Contributor

Sorry I'll reply on the JIRA, but I think this is a good step, I don't have a good solution for introducing the more complex behavior without breaking compatibility other then making it an additional argument. We can discuss more on the JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants