Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17875: [C++] Remove assorted pre-C++17 compatibility measures #14263

Merged
merged 1 commit into from
Sep 28, 2022
Merged

ARROW-17875: [C++] Remove assorted pre-C++17 compatibility measures #14263

merged 1 commit into from
Sep 28, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 28, 2022

No description provided.

@pitrou
Copy link
Member Author

pitrou commented Sep 28, 2022

Revision: 7e3a408

Submitted crossbow builds: ursacomputing/crossbow @ cpp17-compat-0

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17875

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou pitrou merged commit 9af43f1 into apache:master Sep 28, 2022
@pitrou pitrou deleted the ARROW-17875-cpp17 branch September 28, 2022 14:02
@ursabot
Copy link

ursabot commented Sep 29, 2022

Benchmark runs are scheduled for baseline = e42b26a and contender = 9af43f1. 9af43f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.07% ⬆️0.2%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.27%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9af43f11 ec2-t3-xlarge-us-east-2
[Failed] 9af43f11 test-mac-arm
[Failed] 9af43f11 ursa-i9-9960x
[Finished] 9af43f11 ursa-thinkcentre-m75q
[Finished] e42b26af ec2-t3-xlarge-us-east-2
[Failed] e42b26af test-mac-arm
[Failed] e42b26af ursa-i9-9960x
[Finished] e42b26af ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 29, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@pitrou @fatemehp
ARROW-17875: [C++] Remove assorted pre-C++17 compatibility measures (a…
58622e7 
…pache#14263)

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@cyb70289 cyb70289 Awaiting requested review from cyb70289

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitrou @ursabot @lidavidm