-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17880: [Go] Add support for Decimal128 and Decimal256 to CSV writer #14278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when all the tests pass I'll merge it in. Thanks much!!
@mitchdevenport That said, could you create a JIRA card to add decimal128 and decimal256 to the CSV reader side? (or if you feel like it, you can incorporate it into this PR, that's up to you). It would be great to keep the types that can be written and the types that can be read in sync, but it doesn't have to be in this same change. If you don't end up rolling it into this change, I'll try to find the time to add it to the reader after ApacheCon next week. Thanks again! |
@zeroshade Yep, no problem! Intended to make it a separate change but was unsure if the original JIRA would close on merge or not. I've updated the original ticket to be specific to the writer and have a filed a new ticket to track the reader changes: https://issues.apache.org/jira/browse/ARROW-17899 |
Yes, this ticket will close on merge :) |
Benchmark runs are scheduled for baseline = fc9a0e7 and contender = d77176e. d77176e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…iter (apache#14278) Authored-by: Mitch Devenport <mitch@spice.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
No description provided.