ARROW-17697: [Python] Fix Cython warning in types.pxi

[milesgranger]

Will fix ARROW-17697

• Turn warnings into errors
• Change signature of DataType.field as others like StructType.field allowed taking int or str.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17697

[AlenkaF]

I think the changes are clear:

• flag in cmake for Cython compilation that turns warnings to errors,
• changing signatures to fix for reported warnings in pyarrow/types.pxi when compiling PyArrow.

And just to check my understanding: you used cpdef here because you changed def and we want it to be callable from Python? And the error was happening due to the field method being a cdef function in the DataType superclass?

[milesgranger]

Yepsi pepsi, that's right. I have nothing to add to your understanding. :)

[ursabot]

Benchmark runs are scheduled for baseline = 0aacc28 and contender = d8d0323. d8d0323 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.89% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d8d0323f ec2-t3-xlarge-us-east-2
[Failed] d8d0323f test-mac-arm
[Failed] d8d0323f ursa-i9-9960x
[Finished] d8d0323f ursa-thinkcentre-m75q
[Finished] 0aacc28c ec2-t3-xlarge-us-east-2
[Failed] 0aacc28c test-mac-arm
[Failed] 0aacc28c ursa-i9-9960x
[Finished] 0aacc28c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java