Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17771: [Docs][Python] Add the use of CONDA_DLL_SEARCH_MODIFICATION_ENABLE to the docs #14302

Merged
merged 3 commits into from
Oct 6, 2022
Merged

ARROW-17771: [Docs][Python] Add the use of CONDA_DLL_SEARCH_MODIFICATION_ENABLE to the docs #14302

merged 3 commits into from
Oct 6, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 4, 2022

This PR adds info to the Python dev docs about the need to use CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1 in Python versions < 3.10.

Screenshot 2022-10-04 at 09 00 54

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

https://issues.apache.org/jira/browse/ARROW-17771

@AlenkaF AlenkaF changed the title ARROW-17771: [Python] Python does not find the DLLs correctly on Windows ARROW-17771: [Docs][Python] Add the use of CONDA_DLL_SEARCH_MODIFICATION_ENABLE to the docs Oct 4, 2022
@pitrou
Copy link
Member

pitrou commented Oct 4, 2022

@wjones127 Would you like to review the wording here?

jorisvandenbossche
jorisvandenbossche reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Show resolved Hide resolved
AlenkaF and others added 2 commits October 4, 2022 19:14
@AlenkaF @jorisvandenbossche
Update docs/source/developers/python.rst
4054390 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF
Change text in the note
067a9a2
@jorisvandenbossche jorisvandenbossche merged commit d31f3d9 into apache:master Oct 6, 2022
@AlenkaF AlenkaF deleted the ARROW-17771 branch October 6, 2022 07:44
@ursabot
Copy link

ursabot commented Oct 6, 2022

Benchmark runs are scheduled for baseline = 287ede7 and contender = d31f3d9. d31f3d9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d31f3d94 ec2-t3-xlarge-us-east-2
[Failed] d31f3d94 test-mac-arm
[Failed] d31f3d94 ursa-i9-9960x
[Finished] d31f3d94 ursa-thinkcentre-m75q
[Finished] 287ede7b ec2-t3-xlarge-us-east-2
[Failed] 287ede7b test-mac-arm
[Failed] 287ede7b ursa-i9-9960x
[Finished] 287ede7b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@AlenkaF @fatemehp
ARROW-17771: [Docs][Python] Add the use of CONDA_DLL_SEARCH_MODIFICAT…
c87cc12 
…ION_ENABLE to the docs (apache#14302)

This PR adds info to the Python dev docs about the need to use `CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1` in Python versions < 3.10.

![Screenshot 2022-10-04 at 09 00 54](https://user-images.githubusercontent.com/16418547/193755270-d289d3b0-55a5-4c70-b2ab-0d6ca3a2ecbe.png)

Lead-authored-by: Alenka Frim <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@asfimport asfimport mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
Component: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlenkaF @pitrou @ursabot @jorisvandenbossche @wjones127