Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17950: [Docs][Python] Add more info about the change in PyArrow C++ API #14333

Merged
merged 5 commits into from
Oct 12, 2022
Merged

ARROW-17950: [Docs][Python] Add more info about the change in PyArrow C++ API #14333

merged 5 commits into from
Oct 12, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 6, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

https://issues.apache.org/jira/browse/ARROW-17950

jorisvandenbossche
jorisvandenbossche reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/source/python/integration/extending.rst Outdated Show resolved Hide resolved
docs/source/python/integration/extending.rst Outdated Show resolved Hide resolved
docs/source/python/integration/extending.rst Outdated Show resolved Hide resolved
@AlenkaF @jorisvandenbossche
Apply suggestions from code review - Joris
49f8dcb 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF AlenkaF requested a review from pitrou October 11, 2022 14:58
pitrou
pitrou approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jorisvandenbossche Any other opinions?

@jorisvandenbossche jorisvandenbossche merged commit f25d88e into apache:master Oct 12, 2022
@AlenkaF AlenkaF deleted the ARROW-17950 branch October 12, 2022 08:16
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = 2724150 and contender = f25d88e. f25d88e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.29% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f25d88ed ec2-t3-xlarge-us-east-2
[Failed] f25d88ed test-mac-arm
[Failed] f25d88ed ursa-i9-9960x
[Finished] f25d88ed ursa-thinkcentre-m75q
[Finished] 2724150e ec2-t3-xlarge-us-east-2
[Failed] 2724150e test-mac-arm
[Failed] 2724150e ursa-i9-9960x
[Finished] 2724150e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 12, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlenkaF @ursabot @kou @jorisvandenbossche @pitrou