Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel #14342

Merged
merged 3 commits into from
Oct 10, 2022
Merged

ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel #14342

merged 3 commits into from
Oct 10, 2022

Commits on Oct 7, 2022

  1. ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel 

    If we build with -DCMAKE_BUILD_TYPE=MinSizeRel, our SIMD related code
may violate the one-definition-rule. See also ARROW-15664 and
https://issues.apache.org/jira/browse/ARROW-15678?focusedCommentId=17613909#comment-17613909
for details.

This change prevents the one-definition-rule violation by forcing
inlining as much as possible.
    @kou
    kou committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    22cdaf6 View commit details
    Browse the repository at this point in the history

  2. Always optimize SIMD codes

    @kou
    kou committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    1f4d567 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Refer ARROW-15665 and ARROW-15678 in comment

    @kou
    kou committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    1d2a984 View commit details
    Browse the repository at this point in the history