Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17891: [Docs][Python] Update and sync Win section of the developers/python page #14350

Merged
merged 10 commits into from
Oct 19, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 8, 2022

This PR updates Windows section of the Python Development page. Main changes:

  • use Python 3.10 (also in instructions for Linux/MacOs)
  • definition of PATH not needed as Python doesn't search in PATH for dlls anymore (3.8 +)
  • use CONDA_PREFIX to define ARROW_HOME as in other parts of the docs
  • remove Running C++ unit tests for Python integration section (C++ unit tests are part of pytest-based test module as of ARROW-17016: [C++][Python] Move Arrow Python C++ tests into Cython #14117)

cc @wjones127 @jorisvandenbossche

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments / questions

docs/source/developers/python.rst Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Show resolved Hide resolved
@AlenkaF
Copy link
Member Author

AlenkaF commented Oct 17, 2022

@jorisvandenbossche I think this changes would be good to have in 10.0.0. You think it is ready to get merged with ARROW_HOME=%CONDA_PREFIX% before the branch freeze?

@jorisvandenbossche jorisvandenbossche merged commit 183517c into apache:master Oct 19, 2022
@jorisvandenbossche
Copy link
Member

Thanks!

@AlenkaF AlenkaF deleted the ARROW-17891 branch October 19, 2022 08:08
kou pushed a commit that referenced this pull request Oct 20, 2022
…pers/python page (#14350)

This PR updates Windows section of the Python Development page. Main changes:

- use Python 3.10 (also in instructions for Linux/MacOs)
- definition of `PATH` not needed as Python doesn't search in `PATH` for dlls anymore ([3.8 +](https://bugs.python.org/issue43173))
- use `CONDA_PREFIX` to define `ARROW_HOME` as in other parts of the docs
- remove **Running C++ unit tests for Python integration** section (C++ unit tests are part of `pytest`-based test module as of #14117)

cc @wjones127 @jorisvandenbossche 

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants