Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17973: [C++] Expression::ToString wrong for nullary function call #14370

Merged
merged 3 commits into from Oct 11, 2022

Conversation

sanjibansg
Copy link
Contributor

This PR fixes the ToString() method in the Expression class to handle functions with no arguments.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @sanjibansg . Just one suggestion below.

cpp/src/arrow/compute/exec/expression_test.cc Show resolved Hide resolved
@pitrou pitrou merged commit 7be5e95 into apache:master Oct 11, 2022
@sanjibansg sanjibansg deleted the fix-tostring branch October 11, 2022 14:56
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = 3d7f2f2 and contender = 7be5e95. 7be5e95 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7be5e95e ec2-t3-xlarge-us-east-2
[Failed] 7be5e95e test-mac-arm
[Failed] 7be5e95e ursa-i9-9960x
[Finished] 7be5e95e ursa-thinkcentre-m75q
[Finished] 3d7f2f22 ec2-t3-xlarge-us-east-2
[Failed] 3d7f2f22 test-mac-arm
[Failed] 3d7f2f22 ursa-i9-9960x
[Finished] 3d7f2f22 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants