-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18027: [Dev][Archery][Crossbow] Reuse GitHub Token #14398
Conversation
|
@@ -310,9 +308,6 @@ def asset_callback(task_name, task, asset): | |||
help='Crossbow repository on github to use') | |||
@click.option('--fetch/--no-fetch', default=True, | |||
help='Fetch references (branches and tags) from the remote') | |||
@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have to remove github_token
from the function signature too?
def report_pr(obj, arrow_remote, crossbow, fetch, github_token, job_name,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark runs are scheduled for baseline = 44058ff and contender = 0e80c4f. 0e80c4f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.