Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18027: [Dev][Archery][Crossbow] Reuse GitHub Token #14398

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

kou
Copy link
Member

@kou kou commented Oct 13, 2022

No description provided.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Oct 13, 2022

@raulcd @kszucs What do you think about this?

@@ -310,9 +308,6 @@ def asset_callback(task_name, task, asset):
help='Crossbow repository on github to use')
@click.option('--fetch/--no-fetch', default=True,
help='Fetch references (branches and tags) from the remote')
@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have to remove github_token from the function signature too?

def report_pr(obj, arrow_remote, crossbow, fetch, github_token, job_name,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
I'll fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kou kou merged commit 0e80c4f into apache:master Oct 14, 2022
@kou kou deleted the crossbow-reuse-github-token branch October 14, 2022 12:57
@ursabot
Copy link

ursabot commented Oct 15, 2022

Benchmark runs are scheduled for baseline = 44058ff and contender = 0e80c4f. 0e80c4f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0e80c4f6 ec2-t3-xlarge-us-east-2
[Failed] 0e80c4f6 test-mac-arm
[Failed] 0e80c4f6 ursa-i9-9960x
[Finished] 0e80c4f6 ursa-thinkcentre-m75q
[Finished] 44058ffd ec2-t3-xlarge-us-east-2
[Failed] 44058ffd test-mac-arm
[Failed] 44058ffd ursa-i9-9960x
[Finished] 44058ffd ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants