Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-18053: [Dev] Fix a bug that merge_arrow_pr.py doesn't detect Co-authored-by: #14416

Merged
merged 1 commit into from
Oct 15, 2022
Merged

ARROW-18053: [Dev] Fix a bug that merge_arrow_pr.py doesn't detect Co-authored-by: #14416

merged 1 commit into from
Oct 15, 2022

Conversation

kou
Copy link
Member

@kou kou commented Oct 14, 2022

For example, Co-authored-by: in
41b7f26 isn't detected.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-18053

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
ARROW-18053: [Dev] Fix a bug that merge_arrow_pr.py doesn't detect Co…
1aa6efc 
…-authored-by:

For example, Co-authored-by: in
apache@41b7f26
isn't detected.
@kou kou force-pushed the dev-merge-missing-multiline branch from 20eaf22 to 1aa6efc Compare October 14, 2022 13:51
pitrou
pitrou approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's interesting that it hadn't been noticed before.

@nealrichardson nealrichardson merged commit 0b86e40 into apache:master Oct 15, 2022
@kou kou deleted the dev-merge-missing-multiline branch October 15, 2022 21:00
@ursabot
Copy link

ursabot commented Oct 25, 2022

Benchmark runs are scheduled for baseline = f5e592e and contender = 0b86e40. 0b86e40 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.54% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0b86e406 ec2-t3-xlarge-us-east-2
[Failed] 0b86e406 test-mac-arm
[Finished] 0b86e406 ursa-i9-9960x
[Failed] 0b86e406 ursa-thinkcentre-m75q
[Finished] f5e592eb ec2-t3-xlarge-us-east-2
[Failed] f5e592eb test-mac-arm
[Finished] f5e592eb ursa-i9-9960x
[Failed] f5e592eb ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 25, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kou @ursabot @pitrou @nealrichardson