-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18069: [Docs] Suggest using force with lease initially #14430
Conversation
docs/source/developers/overview.rst
Outdated
$ git push --force origin branch | ||
$ git push --force-with-lease origin branch | ||
|
||
If that fails, use a regular ``--force`` push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of stating the --force
alternative, I think it would be better to explain in one simple sentence why --force-with-lease
is preferrable over --force
(because that option is not very well-known).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Needed two sentences. Hopefully ok. Not sure if a link to the documentation is needed.
Thanks @bkmgit, I think few of us knew about this safer alternative. |
This ensures commits are not lost unintentionally, see https://itnext.io/git-force-vs-force-with-lease-9d0e753e8c41 Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
I'm going to merge this. Thank you for the contribution! |
This ensures commits are not lost unintentionally, see https://itnext.io/git-force-vs-force-with-lease-9d0e753e8c41 Lead-authored-by: Benson Muite <bkmgit@users.noreply.github.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Benchmark runs are scheduled for baseline = b7e60c7 and contender = 2f17b54. 2f17b54 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
This ensures commits are not lost unintentionally, see
https://itnext.io/git-force-vs-force-with-lease-9d0e753e8c41