Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-18072: [C++] Can't use bundled ORC with CMake 3.10 #14432

Merged
merged 1 commit into from
Oct 17, 2022
Merged

ARROW-18072: [C++] Can't use bundled ORC with CMake 3.10 #14432

merged 1 commit into from
Oct 17, 2022

Conversation

kou
Copy link
Member

@kou kou commented Oct 17, 2022

Because CMake 3.10 doesn't support target_link_libraries() against an IMPORTED target:

https://cmake.org/cmake/help/latest/release/3.11.html#commands

The target_link_libraries() command learned to set the
INTERFACE_LINK_LIBRARIES property on Imported Targets.

@kou
ARROW-18072: [C++] Can't use bundled ORC with CMake 3.10
d898447 
Because CMake 3.10 doesn't support target_link_libraries() against an
IMPORTED target:

https://cmake.org/cmake/help/latest/release/3.11.html#commands

> The target_link_libraries() command learned to set the
> INTERFACE_LINK_LIBRARIES property on Imported Targets.
@kou
Copy link
Member Author

kou commented Oct 17, 2022

@github-actions crossbow submit test-ubuntu-18.04-cpp* verify-rc-source--ubuntu-18.04-

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-18072

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

cyb70289
cyb70289 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
Hopefully we can upgrade cmake soon.

@kou
Copy link
Member Author

kou commented Oct 17, 2022

We will be able to require CMake 3.16 or later since 12.0.0 because Ubuntu 18.04 will reach EOL at 2023-04. :-)

https://wiki.ubuntu.com/Releases

Version Code name Docs Release End of Standard Support
Ubuntu 18.04.6 LTS Bionic Beaver Changes September 17.2021 April 2023

@github-actions
Copy link

Revision: d898447

Submitted crossbow builds: ursacomputing/crossbow @ actions-c6bb247e61

Task Status
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
verify-rc-source-cpp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-csharp-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-18.04-amd64 Github Actions

@kou kou merged commit 66874f5 into apache:master Oct 17, 2022
@kou kou deleted the cpp-cmake-bundled-orc branch October 17, 2022 05:54
kou added a commit that referenced this pull request Oct 20, 2022
@kou
ARROW-18072: [C++] Can't use bundled ORC with CMake 3.10 (#14432)
4a985ff 
Because CMake 3.10 doesn't support target_link_libraries() against an IMPORTED target:

https://cmake.org/cmake/help/latest/release/3.11.html#commands

> The target_link_libraries() command learned to set the
> INTERFACE_LINK_LIBRARIES property on Imported Targets.

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@ursabot
Copy link

ursabot commented Oct 26, 2022

Benchmark runs are scheduled for baseline = 9b23bc4 and contender = 66874f5. 66874f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 66874f5a ec2-t3-xlarge-us-east-2
[Failed] 66874f5a test-mac-arm
[Finished] 66874f5a ursa-i9-9960x
[Failed] 66874f5a ursa-thinkcentre-m75q
[Finished] 9b23bc45 ec2-t3-xlarge-us-east-2
[Failed] 9b23bc45 test-mac-arm
[Finished] 9b23bc45 ursa-i9-9960x
[Failed] 9b23bc45 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 26, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@asfimport asfimport mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kou @ursabot @cyb70289