-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17849: [R][Docs] Document changes due to C++17 for centos-7 users #14440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
approved these changes
Oct 17, 2022
@github-actions crossbow submit r-binary-packages |
Revision: d285a68 Submitted crossbow builds: ursacomputing/crossbow @ actions-aac151bfdd
|
assignUser
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, thanks for taking care of this!
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
034e710
to
fe414af
Compare
kou
pushed a commit
that referenced
this pull request
Oct 20, 2022
…rs (#14440) * `configure` checks that `R CMD config CXX17` is defined and exits early if not * README and install.Rmd discuss system dependencies; install.Rmd includes a bash script to run once to configure your CentOS 7 machine to install arrow. Confirmed that this works manually via docker. * Updated `r_docker_configure.sh` to use that script logic, so our CI should confirm too. * Various cleanups in nixlibs.R: remove checks for gcc 4.8/4.9 all over, updated system requirements check to handle case of devtoolset-8 but no openssl/curl * Unrelated purge of windows build script handling for rtools35 Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure
checks thatR CMD config CXX17
is defined and exits early if notr_docker_configure.sh
to use that script logic, so our CI should confirm too.