Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17849: [R][Docs] Document changes due to C++17 for centos-7 users #14440

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Oct 17, 2022

  • configure checks that R CMD config CXX17 is defined and exits early if not
  • README and install.Rmd discuss system dependencies; install.Rmd includes a bash script to run once to configure your CentOS 7 machine to install arrow. Confirmed that this works manually via docker.
  • Updated r_docker_configure.sh to use that script logic, so our CI should confirm too.
  • Various cleanups in nixlibs.R: remove checks for gcc 4.8/4.9 all over, updated system requirements check to handle case of devtoolset-8 but no openssl/curl
  • Unrelated purge of windows build script handling for rtools35

@nealrichardson
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: d285a68

Submitted crossbow builds: ursacomputing/crossbow @ actions-aac151bfdd

Task Status
r-binary-packages Github Actions

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, thanks for taking care of this!

r/vignettes/install.Rmd Show resolved Hide resolved
r/DESCRIPTION Outdated Show resolved Hide resolved
@nealrichardson nealrichardson merged commit cd33544 into apache:master Oct 18, 2022
@nealrichardson nealrichardson deleted the centos-docs branch October 18, 2022 00:46
kou pushed a commit that referenced this pull request Oct 20, 2022
…rs (#14440)

* `configure` checks that `R CMD config CXX17` is defined and exits early if not
* README and install.Rmd discuss system dependencies; install.Rmd includes a bash script to run once to configure your CentOS 7 machine to install arrow. Confirmed that this works manually via docker.
* Updated `r_docker_configure.sh` to use that script logic, so our CI should confirm too.
* Various cleanups in nixlibs.R: remove checks for gcc 4.8/4.9 all over, updated system requirements check to handle case of devtoolset-8 but no openssl/curl
* Unrelated purge of windows build script handling for rtools35

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants