ARROW-18080: [C++] Remove gcc <= 4.9 workarounds #14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
approved these changes
Oct 17, 2022
ci/conan/all/conanfile.py
Outdated
| if self._parquet() and self.settings.compiler == "gcc" and self.settings.compiler.version < tools.Version("4.9"): | ||
| return True | ||
| elif version.major >= "2": | ||
| if version.major >= "2": |
There was a problem hiding this comment.
Could you revert all changes in this file?
A Conan package supports multiple versions in the same file. So we still need to support old versions in this file.
pitrou
approved these changes
Oct 17, 2022
|
Could you also fix a CMake lint failure? |
nealrichardson
force-pushed
the
purge-4.9
branch
from
4156c28
to
cfc33dd
Compare
|
Reverted and formatted, ready to merge when CI passes. |
kou
pushed a commit
that referenced
this pull request
Nov 15, 2022
This is most of them I could find. There's another one in `python/pyarrow/src/arrow/python/datetime.cc` to remove but it's more involved. Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most of them I could find. There's another one in
python/pyarrow/src/arrow/python/datetime.ccto remove but it's more involved.