-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18080: [C++] Remove gcc <= 4.9 workarounds #14441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 except ci/conan/all/conanfile.py
ci/conan/all/conanfile.py
Outdated
if self._parquet() and self.settings.compiler == "gcc" and self.settings.compiler.version < tools.Version("4.9"): | ||
return True | ||
elif version.major >= "2": | ||
if version.major >= "2": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert all changes in this file?
A Conan package supports multiple versions in the same file. So we still need to support old versions in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 except for @kou's comment.
Could you also fix a CMake lint failure? |
4156c28
to
cfc33dd
Compare
Reverted and formatted, ready to merge when CI passes. |
This is most of them I could find. There's another one in `python/pyarrow/src/arrow/python/datetime.cc` to remove but it's more involved. Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This is most of them I could find. There's another one in
python/pyarrow/src/arrow/python/datetime.cc
to remove but it's more involved.