Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Fix broken link in R developer setup vignette #14443

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Oct 18, 2022

The link in the final section of the Developer environment setup docs 404s and this points the link to the installation details vignette. I think this is what was intended but let me know.

@bkmgit
Copy link
Contributor

bkmgit commented Oct 18, 2022

Is there a good way to automate checking of links in Rmarkdown? Possibly one could do this in the generated HTML, but maybe checking when parsing maybe more efficient.

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM, and thanks for spotting this and submitting the PR!

r/vignettes/developers/setup.Rmd Outdated Show resolved Hide resolved
@amoeba
Copy link
Member Author

amoeba commented Oct 19, 2022

Thanks for the look @thisisnic. I made the change to the link text in 9701559. This should be good to merge.

@thisisnic thisisnic merged commit c623574 into apache:master Oct 20, 2022
zeroshade pushed a commit to zeroshade/arrow that referenced this pull request Oct 20, 2022
The link in the final section of the [Developer environment setup](https://arrow.apache.org/docs/dev/r/articles/developers/setup.html#other-installation-issues) docs 404s and this points the link to the installation details vignette. I think this is what was intended but let me know.

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
zeroshade pushed a commit to zeroshade/arrow that referenced this pull request Oct 20, 2022
The link in the final section of the [Developer environment setup](https://arrow.apache.org/docs/dev/r/articles/developers/setup.html#other-installation-issues) docs 404s and this points the link to the installation details vignette. I think this is what was intended but let me know.

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants