ARROW-17899: [Go][CSV] Add Decimal support to CSV reader #14504
Conversation
zeroshade
force-pushed
the
arrow-17899-add-decimal-csv
branch
from
fc3d214
to
7c4f8d8
Compare
| field.AppendNull() | ||
| return | ||
| } | ||
| field.(*array.Decimal256Builder).Append(val) |
There was a problem hiding this comment.
Will it be called if r.err != nil?
There was a problem hiding this comment.
the reason for the r.err == nil check is so that we don't lose the first error we find. The assumption being that if we get an error we're going to stop reading after this record and the data is bad anyways.
There was a problem hiding this comment.
if err != nil then val will be the default value, which is 0
|
Benchmark runs are scheduled for baseline = 16fd7f3 and contender = 4755e0f. 4755e0f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.