Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18205: [C++] Substrait consumer is not converting right side references correctly on joins #14558

Merged
merged 2 commits into from Nov 1, 2022

Conversation

vibhatha
Copy link
Collaborator

@vibhatha vibhatha commented Nov 1, 2022

This PR includes modification to the existing join key conversion logic and updated test cases.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@vibhatha
Copy link
Collaborator Author

vibhatha commented Nov 1, 2022

cc @westonpace appreciate your review.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really have any tests with nested references as the join key so this is all theoretical but I think the understanding of indices is slightly off.

cpp/src/arrow/engine/substrait/relation_internal.cc Outdated Show resolved Hide resolved
cpp/src/arrow/engine/substrait/relation_internal.cc Outdated Show resolved Hide resolved
cpp/src/arrow/engine/substrait/relation_internal.cc Outdated Show resolved Hide resolved
@vibhatha vibhatha marked this pull request as ready for review November 1, 2022 09:15
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@westonpace westonpace merged commit e1303aa into apache:master Nov 1, 2022
@ursabot
Copy link

ursabot commented Nov 1, 2022

Benchmark runs are scheduled for baseline = 4755e0f and contender = e1303aa. e1303aa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e1303aac ec2-t3-xlarge-us-east-2
[Failed] e1303aac test-mac-arm
[Finished] e1303aac ursa-i9-9960x
[Finished] e1303aac ursa-thinkcentre-m75q
[Finished] 4755e0f2 ec2-t3-xlarge-us-east-2
[Failed] 4755e0f2 test-mac-arm
[Finished] 4755e0f2 ursa-i9-9960x
[Finished] 4755e0f2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants