New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18205: [C++] Substrait consumer is not converting right side references correctly on joins #14558
Conversation
|
cc @westonpace appreciate your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we really have any tests with nested references as the join key so this is all theoretical but I think the understanding of indices is slightly off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix.
Benchmark runs are scheduled for baseline = 4755e0f and contender = e1303aa. e1303aa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR includes modification to the existing join key conversion logic and updated test cases.