Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18238: [Docs][Python] Improve docs for S3FileSystem #14599

Merged
merged 5 commits into from Nov 9, 2022
Merged

ARROW-18238: [Docs][Python] Improve docs for S3FileSystem #14599

merged 5 commits into from Nov 9, 2022

Conversation

milesgranger
Copy link
Contributor

Will fix ARROW-18238

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

@milesgranger milesgranger changed the title ARROW-18238: [Docs][Python] Improve docs for S3FileSystem and resolve_s3_region ARROW-18238: [Docs][Python] Improve docs for S3FileSystem Nov 7, 2022
@pitrou
Copy link
Member

pitrou commented Nov 8, 2022

@wjones127 Would you like to review this?

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think we can expand the explanation a bit more, added a few suggestions

docs/source/python/filesystems.rst Outdated Show resolved Hide resolved
docs/source/python/filesystems.rst Outdated Show resolved Hide resolved
python/pyarrow/_s3fs.pyx Outdated Show resolved Hide resolved
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

docs/source/python/filesystems.rst Outdated Show resolved Hide resolved
docs/source/python/filesystems.rst Outdated Show resolved Hide resolved
@jorisvandenbossche jorisvandenbossche merged commit 94cf74f into apache:master Nov 9, 2022
@milesgranger milesgranger deleted the ARROW-18238_improve-docs-for-s3filesystem branch November 9, 2022 11:15
@ursabot
Copy link

ursabot commented Nov 9, 2022

Benchmark runs are scheduled for baseline = 92c9f94 and contender = 94cf74f. 94cf74f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.27% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 94cf74f3 ec2-t3-xlarge-us-east-2
[Finished] 94cf74f3 test-mac-arm
[Finished] 94cf74f3 ursa-i9-9960x
[Finished] 94cf74f3 ursa-thinkcentre-m75q
[Finished] 92c9f942 ec2-t3-xlarge-us-east-2
[Finished] 92c9f942 test-mac-arm
[Finished] 92c9f942 ursa-i9-9960x
[Finished] 92c9f942 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants