Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18291: [Release][Docs] Update how to release #14612

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

kou
Copy link
Member

@kou kou commented Nov 9, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Nov 9, 2022

@raulcd @assignUser You may be interested in this.

@raulcd
Copy link
Member

raulcd commented Nov 9, 2022

@github-actions crossbow submit preview-docs

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Revision: 8216ae5

Submitted crossbow builds: ursacomputing/crossbow @ actions-81ab023231

Task Status
preview-docs Github Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou , some minor nits

#. Bump versions
#. Update tags for Go modules
#. Update docs
#. Announce the new release
#. Remove old artifacts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the update of the Arrow version on the cookbooks as a post-release task too? The main problem is that is requires the conda packages to be available at the moment and they might take a while. I am monitoring for them to be available for 10.0.0 to update the cookbooks version at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't know that!
I've added a place holder for it. Could you fill it in a follow-up pull request?

dev/release/post-02-binary.sh <version> <rc number>
.. code-block:: Bash

## You need to run this on macOS that Homebrew is installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, this should also work with brewlinux, that's how I did the 9.0.0 one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really!? I didn't know that!

I've added "or Linux".

:class-title: sd-fs-5
:class-container: sd-shadow-md

The API documentations are generated in release process. We just need to upload the generated API documentations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The API documentations are generated in release process. We just need to upload the generated API documentations:
The API documentations are generated in the release process. We just need to upload the generated API documentations:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you can also remove "API", since this is for all docs, not just API docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Fixed them.

@raulcd
Copy link
Member

raulcd commented Nov 9, 2022

Changes can be found here from the pr-docs job: http://crossbow.voltrondata.com/pr_docs/14612/developers/release.html

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -216,123 +216,365 @@ Be sure to go through on the following checklist:
#. Start the new version on JIRA on the ARROW project
#. Start the new version on JIRA for the related CPP PARQUET version
#. Merge changes on release branch to maintenance branch for patch releases
#. Add the new release to the Apache Reporter System
#. Upload source
#. Upload binaries
#. Update website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add preparing and releasing the blog post to this list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
I've added a place holder for it. Could you fill it in a follow-up pull request?

:animate: fade-in-slide-down
:class-title: sd-fs-5
:class-container: sd-shadow-md

Fork the `arrow-site repository <https://github.com/apache/arrow-site>`_ and clone it next to the arrow repository.
A PMC member must upload the binary release artifacts to Artifactory:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought committers also have access to the artifactory, not entirely sure though, might need to request the access, couldn't find anything in the infra wiki. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I've fixed.

@kou kou merged commit 4e99f59 into apache:master Nov 10, 2022
@kou kou deleted the release-docs-update branch November 10, 2022 07:55
@ursabot
Copy link

ursabot commented Nov 10, 2022

Benchmark runs are scheduled for baseline = 3767599 and contender = 4e99f59. 4e99f59 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.24% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4e99f59d ec2-t3-xlarge-us-east-2
[Finished] 4e99f59d test-mac-arm
[Finished] 4e99f59d ursa-i9-9960x
[Finished] 4e99f59d ursa-thinkcentre-m75q
[Finished] 37675996 ec2-t3-xlarge-us-east-2
[Finished] 37675996 test-mac-arm
[Finished] 37675996 ursa-i9-9960x
[Failed] 37675996 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants