Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18317: [Go] Dictionary replacement during IPC stream #14636

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

zeroshade
Copy link
Member

Fix dictionary replacement for IPC streams. Currently they incorrectly get concatenated together instead of replaced when not using deltas. This will properly replace dictionaries when encountering a non-delta dictionary message.

@zeroshade zeroshade marked this pull request as ready for review November 14, 2022 17:02
@github-actions
Copy link

@zeroshade zeroshade merged commit dc7f1ee into apache:master Nov 15, 2022
@zeroshade zeroshade deleted the arrow-18317-dict-ipc branch November 15, 2022 15:56
@ursabot
Copy link

ursabot commented Nov 15, 2022

Benchmark runs are scheduled for baseline = 058d4f6 and contender = dc7f1ee. dc7f1ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.07%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.76% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dc7f1ee2 ec2-t3-xlarge-us-east-2
[Finished] dc7f1ee2 test-mac-arm
[Finished] dc7f1ee2 ursa-i9-9960x
[Finished] dc7f1ee2 ursa-thinkcentre-m75q
[Finished] 058d4f69 ec2-t3-xlarge-us-east-2
[Finished] 058d4f69 test-mac-arm
[Finished] 058d4f69 ursa-i9-9960x
[Finished] 058d4f69 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kou pushed a commit that referenced this pull request Nov 15, 2022
Fix dictionary replacement for IPC streams. Currently they incorrectly get concatenated together instead of replaced when not using deltas. This will properly replace dictionaries when encountering a non-delta dictionary message.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants