Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18406: [C++] Can't build Arrow with Substrait on Ubuntu 20.04 #14735

Conversation

westonpace
Copy link
Member

No description provided.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@westonpace
Copy link
Member Author

This is something I think we will eventually want a good way to regress. Perhaps a nightly job for Ubuntu 20.04 that uses the system libraries instead of conda? I say this because I think this is the second or third time a regression of this style has been introduced.

@westonpace
Copy link
Member Author

westonpace commented Nov 25, 2022

Also, to be clear, the change here was not actually a code change. We always had has_enum_(). However, in older versions of protoc it is only valid to call has_xyz() if xyz is a message. If xyz is an enum or other simple type (in this case a string) then you have to instead check against the default value for that type (because protobuf, in these cases, does not distinguish between the two)

So when we got the new Substrait version it changed the field enum from a message to a string. Admittedly, this kind of backwards incompatible change should be quite rare.

@paleolimbot
Copy link
Member

I did a local checkout of this and can confirm that it builds with system protoc (at least on my own Ubuntu 20.04 box!).

@westonpace westonpace merged commit 409a95d into apache:master Nov 27, 2022
@ursabot
Copy link

ursabot commented Nov 27, 2022

Benchmark runs are scheduled for baseline = c0b311e and contender = 409a95d. 409a95d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.44%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.7%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 409a95dd ec2-t3-xlarge-us-east-2
[Finished] 409a95dd test-mac-arm
[Finished] 409a95dd ursa-i9-9960x
[Finished] 409a95dd ursa-thinkcentre-m75q
[Finished] c0b311ee ec2-t3-xlarge-us-east-2
[Finished] c0b311ee test-mac-arm
[Finished] c0b311ee ursa-i9-9960x
[Finished] c0b311ee ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants