Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-16266: [R] Add StructArray$create() #14922

Merged
merged 17 commits into from
Jan 11, 2023
Merged

ARROW-16266: [R] Add StructArray$create() #14922

merged 17 commits into from
Jan 11, 2023

Commits on Jan 6, 2023

  1. Delete workaround code and create StructArray$create() function

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ca9dc22 View commit details
    Browse the repository at this point in the history

  2. Add call to new C++ func

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    db28de8 View commit details
    Browse the repository at this point in the history

  3. Add initial sketch of C++ function needed to construct StructArrays f… 

    …rom Arrays
    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    a61a8d0 View commit details
    Browse the repository at this point in the history

  4. Add TODO about how to implement

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    311833a View commit details
    Browse the repository at this point in the history

  5. Use the method that works with field_names instead

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    1f3ae6d View commit details
    Browse the repository at this point in the history

  6. Add TODOs

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    2be5993 View commit details
    Browse the repository at this point in the history

  7. Update function to work with data.frames and Arrays

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    470945f View commit details
    Browse the repository at this point in the history

  8. Run styler

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    79816f6 View commit details
    Browse the repository at this point in the history

  9. Convert dots to Arrays

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    5b41c32 View commit details
    Browse the repository at this point in the history

  10. Remove whitespace to trigger CI

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0af0508 View commit details
    Browse the repository at this point in the history

  11. Add additional function that takes fields as input

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    35f1b4d View commit details
    Browse the repository at this point in the history

  12. Pass in list of arrays to dots

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    c2e31de View commit details
    Browse the repository at this point in the history

  13. Fix failing tests

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    e9fe465 View commit details
    Browse the repository at this point in the history

  14. Delete extraneous function

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    7267308 View commit details
    Browse the repository at this point in the history

  15. Re-organise and simplify

    @thisisnic
    thisisnic committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    100c24e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Simplify

    @thisisnic
    thisisnic committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    ef8a225 View commit details
    Browse the repository at this point in the history

  2. Update r/tests/testthat/test-Array.R 

    Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
    @thisisnic @paleolimbot
    thisisnic and paleolimbot committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    0e170fc View commit details
    Browse the repository at this point in the history