ARROW-308: UnionListWriter.setPosition() should not call startList() #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
merged |
adeneche
pushed a commit
to adeneche/arrow
that referenced
this pull request
Sep 28, 2016
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
This function was implemented incorrectly in the original source code from Impala. The bug never presented itself because Impala allocates a much larger buffer than is required for the data page rather than using the `MaxBufferSize` value. In a worst case scenario, the RleEncoder can result in a concatenation of short RLE runs of 8 values (the minimum for RLE). For example: 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 ... In encoded form, each RLE run occupies 2 bytes (for bit width 1). Thus 1024 values with this structure and bit width 1, at least 256 bytes are required to fully encode. If these were encoded as all literal runs, you can encode up to 504 values in a literal run (plus the indicator byte). Thus, in the same case (bit width 1) only (504 + 504 + 16) 64 + 64 + 3 = 131 bytes are required. This should also fix PARQUET-698. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#150 from wesm/PARQUET-676 and squashes the following commits: 6ca44a8 [Wes McKinney] clang-format e48b0bf [Wes McKinney] Fix maximum buffer sizing for hybrid RLE encoding case where short RLE runs use more space than mostly literal runs
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
This function was implemented incorrectly in the original source code from Impala. The bug never presented itself because Impala allocates a much larger buffer than is required for the data page rather than using the `MaxBufferSize` value. In a worst case scenario, the RleEncoder can result in a concatenation of short RLE runs of 8 values (the minimum for RLE). For example: 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 ... In encoded form, each RLE run occupies 2 bytes (for bit width 1). Thus 1024 values with this structure and bit width 1, at least 256 bytes are required to fully encode. If these were encoded as all literal runs, you can encode up to 504 values in a literal run (plus the indicator byte). Thus, in the same case (bit width 1) only (504 + 504 + 16) 64 + 64 + 3 = 131 bytes are required. This should also fix PARQUET-698. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#150 from wesm/PARQUET-676 and squashes the following commits: 6ca44a8 [Wes McKinney] clang-format e48b0bf [Wes McKinney] Fix maximum buffer sizing for hybrid RLE encoding case where short RLE runs use more space than mostly literal runs Change-Id: Ia333b7b2ecd1d5dbc54842e584aad6afabaddb38
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
This function was implemented incorrectly in the original source code from Impala. The bug never presented itself because Impala allocates a much larger buffer than is required for the data page rather than using the `MaxBufferSize` value. In a worst case scenario, the RleEncoder can result in a concatenation of short RLE runs of 8 values (the minimum for RLE). For example: 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 ... In encoded form, each RLE run occupies 2 bytes (for bit width 1). Thus 1024 values with this structure and bit width 1, at least 256 bytes are required to fully encode. If these were encoded as all literal runs, you can encode up to 504 values in a literal run (plus the indicator byte). Thus, in the same case (bit width 1) only (504 + 504 + 16) 64 + 64 + 3 = 131 bytes are required. This should also fix PARQUET-698. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#150 from wesm/PARQUET-676 and squashes the following commits: 6ca44a8 [Wes McKinney] clang-format e48b0bf [Wes McKinney] Fix maximum buffer sizing for hybrid RLE encoding case where short RLE runs use more space than mostly literal runs Change-Id: Ia333b7b2ecd1d5dbc54842e584aad6afabaddb38
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
This function was implemented incorrectly in the original source code from Impala. The bug never presented itself because Impala allocates a much larger buffer than is required for the data page rather than using the `MaxBufferSize` value. In a worst case scenario, the RleEncoder can result in a concatenation of short RLE runs of 8 values (the minimum for RLE). For example: 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 ... In encoded form, each RLE run occupies 2 bytes (for bit width 1). Thus 1024 values with this structure and bit width 1, at least 256 bytes are required to fully encode. If these were encoded as all literal runs, you can encode up to 504 values in a literal run (plus the indicator byte). Thus, in the same case (bit width 1) only (504 + 504 + 16) 64 + 64 + 3 = 131 bytes are required. This should also fix PARQUET-698. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#150 from wesm/PARQUET-676 and squashes the following commits: 6ca44a8 [Wes McKinney] clang-format e48b0bf [Wes McKinney] Fix maximum buffer sizing for hybrid RLE encoding case where short RLE runs use more space than mostly literal runs Change-Id: Ia333b7b2ecd1d5dbc54842e584aad6afabaddb38
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
This function was implemented incorrectly in the original source code from Impala. The bug never presented itself because Impala allocates a much larger buffer than is required for the data page rather than using the `MaxBufferSize` value. In a worst case scenario, the RleEncoder can result in a concatenation of short RLE runs of 8 values (the minimum for RLE). For example: 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 ... In encoded form, each RLE run occupies 2 bytes (for bit width 1). Thus 1024 values with this structure and bit width 1, at least 256 bytes are required to fully encode. If these were encoded as all literal runs, you can encode up to 504 values in a literal run (plus the indicator byte). Thus, in the same case (bit width 1) only (504 + 504 + 16) 64 + 64 + 3 = 131 bytes are required. This should also fix PARQUET-698. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#150 from wesm/PARQUET-676 and squashes the following commits: 6ca44a8 [Wes McKinney] clang-format e48b0bf [Wes McKinney] Fix maximum buffer sizing for hybrid RLE encoding case where short RLE runs use more space than mostly literal runs Change-Id: Ia333b7b2ecd1d5dbc54842e584aad6afabaddb38
rafael-telles
added a commit
to rafael-telles/arrow
that referenced
this pull request
Oct 12, 2021
…a-serialization [FlightSql] Fix Schema Serialization
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Aug 31, 2022
* Initial commit * Remove WIP code * Result null result in internal logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.