Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15218: [Python] Remove auto generated pyarrow_api.h and pyarrow_lib.h #15219

Merged
merged 1 commit into from
Jan 9, 2023
Merged

GH-15218: [Python] Remove auto generated pyarrow_api.h and pyarrow_lib.h #15219

merged 1 commit into from
Jan 9, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jan 6, 2023 •
edited by github-actions bot
Loading

We can use auto generated lib_api.h and lib.h instead of pre committed pyarrow_api.h and pyarrow_lib.h because we unified build system of PyArrow and PyArrow C++.

@kou
apacheGH-15218: [Python] Remove auto generated pyarrow_api.h and pyar…
dc0169e 
…row_lib.h

We can use auto generated `lib_api.h` and `lib.h` instead of pre
committed `pyarrow_api.h` and `pyarrow_lib.h` because we unified build
system of PyArrow and PyArrow C++.
@kou
Copy link
Member Author

kou commented Jan 6, 2023

@github-actions crossbow submit -g python

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

⚠️ GitHub issue #15218 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Revision: dc0169e

Submitted crossbow builds: ursacomputing/crossbow @ actions-8b4269f1f6

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-1.0 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-upstream_devel Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions
test-conda-python-3.9-spark-master Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure

AlenkaF
AlenkaF approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you Kou!

@kou kou merged commit 4d31b1e into apache:master Jan 9, 2023
@kou kou deleted the python-use-auto-generated-lib-api branch January 9, 2023 12:58
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Jan 9, 2023
@kou @vibhatha
apacheGH-15218: [Python] Remove auto generated pyarrow_api.h and pyar…
055511f 
…row_lib.h (apache#15219)

We can use auto generated `lib_api.h` and `lib.h` instead of pre committed `pyarrow_api.h` and `pyarrow_lib.h` because we unified build system of PyArrow and PyArrow C++.
* Closes: apache#15218

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@ursabot
Copy link

ursabot commented Jan 9, 2023

Benchmark runs are scheduled for baseline = 878d5ca and contender = 4d31b1e. 4d31b1e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.71% ⬆️0.06%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.2% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4d31b1ef ec2-t3-xlarge-us-east-2
[Failed] 4d31b1ef test-mac-arm
[Finished] 4d31b1ef ursa-i9-9960x
[Finished] 4d31b1ef ursa-thinkcentre-m75q
[Finished] 878d5cac ec2-t3-xlarge-us-east-2
[Finished] 878d5cac test-mac-arm
[Finished] 878d5cac ursa-i9-9960x
[Finished] 878d5cac ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 10, 2023
@kou @EpsilonPrime
apacheGH-15218: [Python] Remove auto generated pyarrow_api.h and pyar…
8741c83 
…row_lib.h (apache#15219)

We can use auto generated `lib_api.h` and `lib.h` instead of pre committed `pyarrow_api.h` and `pyarrow_lib.h` because we unified build system of PyArrow and PyArrow C++.
* Closes: apache#15218

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlenkaF AlenkaF AlenkaF approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Remove auto generated pyarrow_api.h and pyarrow_lib.h
3 participants
@kou @ursabot @AlenkaF