ARROW-2270: [Python] Fix lifetime of ForeignBuffer base object #1714
Conversation
pitrou
force-pushed
the
ARROW-2270-pyforeignbuffer
branch
from
93f85f9
to
37a9f78
Compare
| // ---------------------------------------------------------------------- | ||
| // Foreign buffer | ||
|
|
||
| Status PyForeignBuffer::Make(const uint8_t* data, int64_t size, PyObject* base, |
There was a problem hiding this comment.
Can you add the description of the JIRA ticket somewhere in the code? I was not aware what went wrong in the initial implementation only from reading the change but I needed the context of the JIRA issue.
There was a problem hiding this comment.
Ok, I added an explanation.
pitrou
force-pushed
the
ARROW-2270-pyforeignbuffer
branch
from
37a9f78
to
217aa3a
Compare
|
(note that a separate Python-facing ForeignBuffer isn't really necessary anymore) |
|
Do we need to remove pyarrow.ForeignBuffer, then? |
|
The alternative would be to expose a factory function, e.g. |
|
Happy with the function. It could be nice to also access the base object later on again but currently I see no need for that. |
pitrou
force-pushed
the
ARROW-2270-pyforeignbuffer
branch
from
217aa3a
to
9e9c8c8
Compare
|
Ok, I did the change to the factory function. |
wesm
force-pushed
the
ARROW-2270-pyforeignbuffer
branch
from
9e9c8c8
to
51f2d85
Compare
|
I added this new function to the API documentation. Merging |
No description provided.