Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2544: [CI] Run the C++ tests with two jobs #1899

Closed
wants to merge 2 commits into from

Conversation

thedrow
Copy link
Contributor

@thedrow thedrow commented Apr 16, 2018

Travis-CI provides workers with two cores. We should use them.
This should make testing our C++ implementation faster.

Travis-CI provides workers with two cores. We should use them.
This should make testing our C++ implementation faster.
@thedrow
Copy link
Contributor Author

thedrow commented Apr 17, 2018

Can anyone restart the build. Travis is having networking issues.

@kou
Copy link
Member

kou commented Apr 17, 2018

Done!

@thedrow
Copy link
Contributor Author

thedrow commented Apr 17, 2018

I'm not sure what's wrong but it doesn't look like my changes caused these failures.

@pitrou
Copy link
Member

pitrou commented Apr 17, 2018

No, this looks like a sporadic error. I restarted the job.

@pitrou
Copy link
Member

pitrou commented Apr 17, 2018

Since we are doing this, perhaps we could reduce verbosity a bit too? Or do people actually read the Valgrind output of successful builds? @xhochy

@thedrow, by the way, please add "[CI]" in front of the issue title.

@pitrou
Copy link
Member

pitrou commented Apr 17, 2018

(by verbosity, I mean perhaps dropping the -VV option and using --output-on-failure instead)

@thedrow thedrow changed the title Run the C++ tests with two jobs [CI] Run the C++ tests with two jobs Apr 17, 2018
@xhochy
Copy link
Member

xhochy commented Apr 22, 2018

@pitrou I don't care about the valgrind output from successful builds. If there was something interesting in there, it should rather error and urge us to fix it.

@thedrow
Copy link
Contributor Author

thedrow commented May 6, 2018

Can we merge this?

@pitrou
Copy link
Member

pitrou commented May 7, 2018

There are unrelated Travis-CI failures, I'm gonna merge anyway. Thanks @thedrow !

@pitrou pitrou changed the title [CI] Run the C++ tests with two jobs ARROW-2544: [CI] Run the C++ tests with two jobs May 7, 2018
@pitrou pitrou closed this in 2f453a0 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants