Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2518: [Java] Re-instate JDK tests in matrix, but with JDK 8 instead of JDK 7 #1956

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2018

No description provided.

@ghost ghost changed the title re-instate JDK tests in matrix, but with JDK 8 instead of JDK 7 ARROW-2518: [Java] Re-instate JDK tests in matrix, but with JDK 8 instead of JDK 7 Apr 27, 2018
@BryanCutler
Copy link
Member

Sorry, my fault. I saw there was OpenJDK8 already there, but missed that it was for integration tests. I should have looked closer.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on a diff. Not sure why Travis is failing, is it unrelated?

@paddyhoran
Copy link
Contributor

@BryanCutler I think it's unrelated see ARROW-2509. The same thing is happening on 1949

@BryanCutler
Copy link
Member

Great, that's for pointing out the JIRA @paddyhoran , I'll go ahead and commit this since it passed OpenJDK8 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants