New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2563: [Rust] Poor caching in Travis-CI #2021
Conversation
ecb1e9a
to
4a677ed
Compare
Can you rebase this PR so we can check it works with the codecov upload command? |
Sure. Done. |
Thanks. It's down to 10 minutes, which is better, though it seems a lot of third-party stuff still gets recompiled during the build? |
Yes. I'm not sure whether there's a way to avoid the recompilation. Will be back. |
Yes, so the problem is that the coverage step panics with that change. I don't know why: |
3367e93
to
8904cd8
Compare
Back. @pitrou : I think the issue is that In the latest commit I changed the download location to |
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
+ Coverage 86.28% 87.42% +1.14%
==========================================
Files 11 189 +178
Lines 773 29298 +28525
==========================================
+ Hits 667 25615 +24948
- Misses 106 3683 +3577
Continue to review full report at Codecov.
|
It seems there is a kcov error: Did it occur before this PR as well? |
Hmm... seems still because of the |
@pitrou : I changed the code to create a directory |
@sunchao, looks great ! Thank you. |
Thanks @pitrou . Could you help to merge this? |
Done! Thanks for the PR! |
Thanks for merging @pitrou ! |
No description provided.