Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2680: [Python] Add documentation about type inference in Table.from_pandas #2116

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jun 8, 2018

No description provided.

Be aware that Series of the `object` dtype don't carry enough
information to always lead to a meaningful Arrow type. In the case
that we cannot infer a type, e.g. because the DataFrame is of length 0
or the Series only contains None/nan objects the type is set to null.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to note that this behavior can be circumvented by passing an explicit schema, I will make this small tweak

…from_pandas

Add note about passing explicit schema
@wesm
Copy link
Member

wesm commented Jun 8, 2018

+1

@codecov-io
Copy link

Codecov Report

Merging #2116 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2116      +/-   ##
==========================================
+ Coverage   86.37%   86.37%   +<.01%     
==========================================
  Files         230      230              
  Lines       40573    40573              
==========================================
+ Hits        35044    35045       +1     
+ Misses       5529     5528       -1
Impacted Files Coverage Δ
python/pyarrow/table.pxi 68.66% <ø> (ø) ⬆️
cpp/src/arrow/util/thread-pool-test.cc 99.45% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b869a...febfe3d. Read the comment docs.

@wesm wesm closed this in 3155291 Jun 9, 2018
@wesm wesm deleted the ARROW-2680 branch June 9, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants