Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2722: [Python] Sanitize dtype number to handle edge cases #2234

Closed

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jul 9, 2018

No description provided.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this is a nice cleanup. Were you able to reproduce the user's error (I assume the unit test you added does)?

@pitrou
Copy link
Member Author

pitrou commented Jul 9, 2018

Yes I was (on Windows 64).

@codecov-io
Copy link

Codecov Report

Merging #2234 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2234      +/-   ##
=========================================
+ Coverage   84.19%   84.2%   +<.01%     
=========================================
  Files         288     288              
  Lines       44073   44074       +1     
=========================================
+ Hits        37109   37112       +3     
+ Misses       6933    6931       -2     
  Partials       31      31
Impacted Files Coverage Δ
cpp/src/arrow/python/type_traits.h 83.33% <ø> (ø) ⬆️
python/pyarrow/tests/test_convert_pandas.py 94.89% <100%> (+0.01%) ⬆️
cpp/src/arrow/python/numpy_convert.cc 88.15% <100%> (-0.45%) ⬇️
cpp/src/arrow/python/numpy_interop.h 100% <100%> (ø) ⬆️
python/pyarrow/scalar.pxi 62.39% <0%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfa51a...75faf9a. Read the comment docs.

@wesm wesm closed this in b926574 Jul 9, 2018
@pitrou pitrou deleted the ARROW-2722-sanitize-numpy-type-num branch March 2, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants