Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2871: [Python] Raise when calling to_numpy() on boolean array #2277

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Jul 17, 2018

Also marks that to_numpy API is experimental, since we need to figure out what to do about nulls (ARROW-2870)

Change-Id: I88b4c93d849a3c77763cdc179d8ecdae783d13ec
@codecov-io
Copy link

Codecov Report

Merging #2277 into master will increase coverage by 2.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
+ Coverage   84.26%   86.65%   +2.39%     
==========================================
  Files         290      234      -56     
  Lines       44299    41565    -2734     
==========================================
- Hits        37330    36020    -1310     
+ Misses       6942     5545    -1397     
+ Partials       27        0      -27
Impacted Files Coverage Δ
python/pyarrow/tests/test_array.py 100% <100%> (ø) ⬆️
python/pyarrow/array.pxi 66.97% <100%> (+0.45%) ⬆️
go/arrow/array/booleanbuilder.go
go/arrow/array/array.go
go/arrow/type_traits_numeric.gen.go
rust/src/list.rs
go/arrow/array/binary.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/bufferbuilder.go
go/arrow/math/float64_sse4_amd64.go
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5b4d8...c07b9b4. Read the comment docs.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 8443759 Jul 18, 2018
@xhochy xhochy deleted the ARROW-2871 branch July 18, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants