ARROW-2894: [Glib] Adjust tests to format refactor

[xhochy]

cc @kou

I I adjusted the tests to pass. Sadly I had to realise that some of the outputs still don't look pretty. I will change this in a follow-up PR.

There were some issues for me to build Glib in the same environment as the conda one described in https://arrow.apache.org/docs/python/development.html#developing-on-linux-and-macos.

• my configure command was

./configure PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$CONDA_PREFIX/lib/pkgconfig/:$PKG_CONFIG_PATH --prefix=`pwd`/dist

• I had to run cp $CONDA_PREFIX/lib/libarrow* arrow-glib/.libs/ as otherwise the GISCAN step would not suceed. Even setting LD_LIBRARY_PATH did not help
• To run the tests I also needed to add GI.prepend_typelib_path('dist/lib/girepository-1.0/') to c_glib/test/run-test.rb. Otherwise GI.load("Arrow") did not find the necessary definitions.

[kszucs]

Is is_valid intentionally missing here?

[kou]

It seems that new pretty print implementation doesn't show is_valid information.
Can you open a JIRA ticket to discuss what should we do for it?

[xhochy]

is_valid is a duplicate information. We also show nulls in the indices now, before the refactor we have shown undefined values instead there.

[kou]

I see. It makes sense.

[kszucs]

I know You're planning to implement it in a follow-up PR, just suggesting that something like this would be more readable (without type and values):

-- child 0: int32 [
      1,
      2
   ]

[xhochy]

I will take up your suggestion and go for

-- child 0: int32 
  [
      1,
      2
   ]

The line break before [ is mainly due to the fact that makes the array printing code simpler in a first round. We don't need to take the context in consideration then. If that really looks better, we can have a closer look afterwards. My first objective is to iron out any strong misaligments before the release.

[kou]

+1
Thanks for working on it. :-)
There are more works for Ruby. But I'll push some commits for it.

[kou]

It seems that new pretty print implementation doesn't show is_valid information.
Can you open a JIRA ticket to discuss what should we do for it?

[kou]

I'll try GLib build with https://arrow.apache.org/docs/python/development.html#developing-on-linux-and-macos steps.

[kou]

I had to run cp $CONDA_PREFIX/lib/libarrow* arrow-glib/.libs/ as otherwise the GISCAN step would not suceed. Even setting LD_LIBRARY_PATH did not help

I could reproduce this.
I can fix it by setting the following LD_LIBRARY_PATH:

% LD_LIBRARY_PATH=$CONDA_PREFIX/lib make

To run the tests I also needed to add GI.prepend_typelib_path('dist/lib/girepository-1.0/') to c_glib/test/run-test.rb. Otherwise GI.load("Arrow") did not find the necessary definitions.

I could also reproduce this.
We need exports:

diff --git a/c_glib/test/run-test.sh b/c_glib/test/run-test.sh
index d563e858..9abd0354 100755
--- a/c_glib/test/run-test.sh
+++ b/c_glib/test/run-test.sh
@@ -33,6 +33,7 @@ for module in ${modules}; do
     fi
   fi
 done
+export LD_LIBRARY_PATH
 
 if [ -f "Makefile" -a "${NO_MAKE}" != "yes" ]; then
   make -j8 > /dev/null || exit $?
@@ -49,5 +50,6 @@ for module in ${modules}; do
     GI_TYPELIB_PATH="${module_typelib_dir}:${GI_TYPELIB_PATH}"
   fi
 done
+export GI_TYPELIB_PATH
 
 ${GDB} ruby ${test_dir}/run-test.rb "$@"

I could run tests by the following with the above change:

%  LD_LIBRARY_PATH=$CONDA_PREFIX/lib test/run-test.sh 

I'll send a pull request for the exports.

[kou]

CI is green. I'll merge this.