Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2575: [Python] Exclude hidden files starting with . in ParquetManifest #2312

Closed
wants to merge 2 commits into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Jul 24, 2018

I also moved a large nested helper function to a slightly more appropriate place (we need to develop abstract interfaces for different partition schemes)

wesm added 2 commits July 23, 2018 21:50
Change-Id: Icc2af6b784bedddbfbc13d9b8f6e311ff28c237c
Change-Id: Ib5e8fb1bf416a16d8f666dcfd0359d3601e62389
@codecov-io
Copy link

Codecov Report

Merging #2312 into master will increase coverage by 2.39%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
+ Coverage   84.38%   86.77%   +2.39%     
==========================================
  Files         293      237      -56     
  Lines       44784    42056    -2728     
==========================================
- Hits        37789    36494    -1295     
+ Misses       6964     5562    -1402     
+ Partials       31        0      -31
Impacted Files Coverage Δ
python/pyarrow/tests/test_parquet.py 97.02% <100%> (+0.03%) ⬆️
python/pyarrow/parquet.py 91.1% <94.28%> (+0.01%) ⬆️
go/arrow/math/int64_amd64.go
go/arrow/internal/testing/tools/bits.go
go/arrow/math/float64_sse4_amd64.go
go/arrow/memory/buffer.go
go/arrow/math/int64_avx2_amd64.go
go/arrow/math/float64_avx2_amd64.go
go/arrow/memory/memory_sse4_amd64.go
rust/src/buffer.rs
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566e398...92dec69. Read the comment docs.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants