ARROW-402: avoid empty buffers #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to have a direct unit test for this, but I'll make sure it gets triggered by the integration tests, and then fixed by this patch. |
|
@wesm I found the actual bug. |
|
Oh, great. Will merge once the build is green -- I'll see if I can get a green integration test build in ARROW-394 once that's rebased |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#232 from wesm/remove-libparquet_thrift and squashes the following commits: d72546b [Wes McKinney] Remove parquet/thrift subdirectory and separate parquet_thrift library component
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#232 from wesm/remove-libparquet_thrift and squashes the following commits: d72546b [Wes McKinney] Remove parquet/thrift subdirectory and separate parquet_thrift library component Change-Id: I3922cf10aab607e8db5ddabba888a38763ff59f7
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#232 from wesm/remove-libparquet_thrift and squashes the following commits: d72546b [Wes McKinney] Remove parquet/thrift subdirectory and separate parquet_thrift library component Change-Id: I3922cf10aab607e8db5ddabba888a38763ff59f7
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#232 from wesm/remove-libparquet_thrift and squashes the following commits: d72546b [Wes McKinney] Remove parquet/thrift subdirectory and separate parquet_thrift library component Change-Id: I3922cf10aab607e8db5ddabba888a38763ff59f7
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#232 from wesm/remove-libparquet_thrift and squashes the following commits: d72546b [Wes McKinney] Remove parquet/thrift subdirectory and separate parquet_thrift library component Change-Id: I3922cf10aab607e8db5ddabba888a38763ff59f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what's wrong with the accounting of empty buffers.
This seems to fix the issue. Feel free to use it to get unblocked.
allocator.getEmpty() is special and doesn't get accounted since it does not use memory.
@jacques-n: any insight?