Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2990: [GLib] Support building with rpath-ed Arrow C++ on macOS #2374

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Aug 6, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2374 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
+ Coverage   84.49%   84.51%   +0.02%     
==========================================
  Files         293      293              
  Lines       45329    45329              
==========================================
+ Hits        38301    38312      +11     
+ Misses       6997     6990       -7     
+ Partials       31       27       -4
Impacted Files Coverage Δ
go/arrow/math/float64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/int64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
cpp/src/arrow/util/thread-pool-test.cc 99.45% <0%> (+0.54%) ⬆️
go/arrow/math/math_amd64.go 36.84% <0%> (+5.26%) ⬆️
go/arrow/memory/memory_amd64.go 42.85% <0%> (+14.28%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ba33d...c8b5c45. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @kou!

@wesm wesm closed this in da7a48e Aug 6, 2018
wesm pushed a commit that referenced this pull request Aug 6, 2018
Author: Kouhei Sutou <kou@clear-code.com>

Closes #2374 from kou/glib-macos and squashes the following commits:

c8b5c45 <Kouhei Sutou>  Support building with rpath-ed Arrow C++ on macOS
@kou kou deleted the glib-macos branch August 7, 2018 01:46
@xhochy
Copy link
Member

xhochy commented Aug 19, 2018

Sadly this does not resolve it for me but breaks with a new problem: https://issues.apache.org/jira/browse/ARROW-3086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants