ARROW-3060: [C++] Factor out string-to-X conversion routines #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
ARROW-3060-string-conversion
branch
2 times, most recently
from
0559068
to
d5fbf2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2433 +/- ##
==========================================
+ Coverage 85.49% 86.77% +1.28%
==========================================
Files 301 241 -60
Lines 46273 42744 -3529
==========================================
- Hits 39563 37093 -2470
+ Misses 6636 5651 -985
+ Partials 74 0 -74
Continue to review full report at Codecov.
|
wesm
approved these changes
Aug 17, 2018
| }; | ||
|
|
||
| template <class ARROW_TYPE> | ||
| class StringToFloatConverterMixin { |
There was a problem hiding this comment.
Without knowing for sure these numeric converters could end up being hot paths; I suppose we'll find out once we can do some profiling on large datasets
cpp/src/arrow/util/parsing.h
Outdated
| } // namespace internal | ||
| } // namespace arrow | ||
|
|
||
| #endif // ARROW_UTIL_MEMORY_H |
There was a problem hiding this comment.
I opened a JIRA about switching to #pragma once to avoid these sorts of typos
Fix include guard typo Change-Id: I1a3c6af13201617c75c76cab17c8fc6417fefb30
wesm
force-pushed
the
ARROW-3060-string-conversion
branch
from
d5fbf2d
to
67e3315
Compare
stephanie-wang
pushed a commit
to stephanie-wang/arrow
that referenced
this pull request
Aug 29, 2018
Author: Antoine Pitrou <antoine@python.org> Closes apache#2433 from pitrou/ARROW-3060-string-conversion and squashes the following commits: 67e3315 <Antoine Pitrou> ARROW-3060: Factor out string-to-X conversion routines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.