Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3059: [C++] Remove namespace arrow::test #2436

Closed

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 16, 2018

Depends on PR apache/parquet-cpp#487

@codecov-io
Copy link

Codecov Report

Merging #2436 into master will increase coverage by 17.71%.
The diff coverage is 97.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2436       +/-   ##
===========================================
+ Coverage   69.01%   86.73%   +17.71%     
===========================================
  Files          61      239      +178     
  Lines        3234    42607    +39373     
===========================================
+ Hits         2232    36954    +34722     
- Misses        928     5653     +4725     
+ Partials       74        0       -74
Impacted Files Coverage Δ
cpp/src/arrow/memory_pool-test.h 100% <ø> (ø)
cpp/src/arrow/io/io-hdfs-test.cc 17.44% <0%> (ø)
cpp/src/arrow/test-common.h 100% <100%> (ø)
cpp/src/arrow/util/compression-test.cc 100% <100%> (ø)
cpp/src/arrow/ipc/ipc-read-write-test.cc 99.04% <100%> (ø)
cpp/src/arrow/test-util.h 74.8% <100%> (ø)
cpp/src/arrow/util/lazy-test.cc 100% <100%> (ø)
cpp/src/arrow/memory_pool-test.cc 100% <100%> (ø)
cpp/src/arrow/compute/compute-test.cc 99.54% <100%> (ø)
cpp/src/arrow/array-test.cc 100% <100%> (ø)
... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62e07a...47bf2e3. Read the comment docs.

@pitrou
Copy link
Member Author

pitrou commented Aug 16, 2018

Hmm... I'm a bit surprised that CI succeeded without the required parquet-cpp changes.

@wesm
Copy link
Member

wesm commented Aug 16, 2018

Arrow's CI does not build the Parquet unit tests, which I presume are the only things affected by this

@pitrou
Copy link
Member Author

pitrou commented Aug 16, 2018

Ah, I see, thanks.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I will merge this and then we can bump the parquet-cpp Arrow version after we deal with PARQUET-1308

@wesm wesm closed this in 719c954 Aug 16, 2018
@pitrou pitrou deleted the ARROW-3059-remove-test-namespace branch August 16, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants