Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-2965: [Python] Guard against overflow when serializing Numpy uint64 scalar #2463

Closed
wants to merge 2 commits into from
Closed

ARROW-2965: [Python] Guard against overflow when serializing Numpy uint64 scalar #2463

wants to merge 2 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 22, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 22, 2018 •
edited

Codecov Report

Merging #2463 into master will increase coverage by 1.27%.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2463      +/-   ##
==========================================
+ Coverage   86.15%   87.43%   +1.27%     
==========================================
  Files         306      244      -62     
  Lines       46667    43017    -3650     
==========================================
- Hits        40208    37610    -2598     
+ Misses       6389     5407     -982     
+ Partials       70        0      -70
Impacted Files Coverage Δ
python/pyarrow/tests/test_serialization.py 90.12% <100%> (+0.32%) ⬆️
cpp/src/arrow/python/serialize.cc 89.54% <73.07%> (+0.65%) ⬆️
rust/src/lib.rs
go/arrow/array/binarybuilder.go
go/arrow/array/data.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/datatype_fixedwidth.go
go/arrow/math/int64.go
go/arrow/type_string.go
go/arrow/array/numeric.gen.go
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4969da7...c2aad39. Read the comment docs.

wesm
wesm approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @pitrou!

@wesm wesm closed this in 23045d2 Aug 22, 2018
@pitrou pitrou deleted the ARROW-2965-serialize-uint64-overflow branch August 22, 2018 19:09
stephanie-wang pushed a commit to stephanie-wang/arrow that referenced this pull request Aug 29, 2018
@pitrou @stephanie-wang
ARROW-2965: [Python] Guard against overflow when serializing Numpy ui…
3fd1030 
…nt64 scalar

Author: Antoine Pitrou <antoine@python.org>

Closes apache#2463 from pitrou/ARROW-2965-serialize-uint64-overflow and squashes the following commits:

c2aad39 <Antoine Pitrou> Remove unused AppendUInt64
f4f05de <Antoine Pitrou> ARROW-2965:  Guard against overflow when serializing Numpy uint64 scalar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitrou @codecov-io @wesm