New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3160: [Python] Improve pathlib.Path support in parquet and filesystem modules #2506
Conversation
This PR still has test failures. |
Sorry, forgot to prepend with WIP. I'll request your review when it's done. |
@xhochy What do You think about using pathlib in the implementation too? |
…ort pathlib.Path in Filesystem API
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
+ Coverage 86.24% 87.49% +1.25%
==========================================
Files 308 246 -62
Lines 47094 43441 -3653
==========================================
- Hits 40615 38010 -2605
+ Misses 6405 5431 -974
+ Partials 74 0 -74
Continue to review full report at Codecov.
|
@xhochy green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
@pytest.fixture(scope='session') | ||
def datadir(): | ||
return pathlib.Path(__file__).parent / 'data' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be in favor of moving all the test data files to https://github.com/apache/arrow-testing. It would take less stress (for me at least) about adding binary files in the future. There's relatively little need to ship the files (or the unit tests for that matter) with the library
I intend to consolidate parquet test suite a bit in followup PRs.