ARROW-3299: [C++] Make RecordBatchBuilder non-copyable to appease MSVC #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6bee9d1d8ed16443dce9eca5ffe765828fb2c1df
Change-Id: Ie255ba5af9869e176881313b1509e1fddca46e80
Change-Id: I1796b71b3a638c2780c77b78811d52e8f3a3fb80
Change-Id: Ied72c9ef120553472ad9c3611f4d3c3905ce2938
kou
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC generates a copy constructor for this class and gets upset that
ArrayBuilderis non-copyable. It seems that the behavior for classes with dllexport is different which is why the patch earlier today broke the build